Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: chrome/browser/resources/google_now/cards.js

Issue 211663004: Cards Clicked Metrics (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use the new sparse histogram support. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/google_now/cards.js
diff --git a/chrome/browser/resources/google_now/cards.js b/chrome/browser/resources/google_now/cards.js
index 81b89bf90d83aae560eca85ff8b45433e586e96b..00c9b5ddead39e0e15080dc9020a73642713c773 100644
--- a/chrome/browser/resources/google_now/cards.js
+++ b/chrome/browser/resources/google_now/cards.js
@@ -60,7 +60,8 @@ var ChromeNotificationId;
* actionUrls: (ActionUrls|undefined),
* dismissal: Object,
* locationBased: (boolean|undefined),
- * groupName: string
+ * groupName: string,
+ * cardTypeId: (number|undefined)
* }}
*/
var ReceivedNotification;
@@ -91,12 +92,13 @@ var CombinedCard;
*
* @typedef {{
* actionUrls: (ActionUrls|undefined),
+ * cardTypeId: (number|undefined),
* timestamp: number,
* combinedCard: CombinedCard
* }}
*
*/
- var NotificationDataEntry;
+var NotificationDataEntry;
/**
* Names for tasks that can be created by the this file.
@@ -246,9 +248,11 @@ function buildCardSet() {
winningCard.receivedNotification.actionUrls &&
JSON.parse(JSON.stringify(
winningCard.receivedNotification.actionUrls));
-
+ var winningCardTypeId = winningCard &&
+ winningCard.receivedNotification.cardTypeId;
return {
actionUrls: winningActionUrls,
+ cardTypeId: winningCardTypeId,
timestamp: now,
combinedCard: combinedCard
};
« no previous file with comments | « chrome/browser/resources/google_now/background_unittest.gtestjs ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698