Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1564)

Unified Diff: chrome/browser/resources/google_now/background_unittest.gtestjs

Issue 211663004: Cards Clicked Metrics (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use the new sparse histogram support. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/google_now/background.js ('k') | chrome/browser/resources/google_now/cards.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/google_now/background_unittest.gtestjs
diff --git a/chrome/browser/resources/google_now/background_unittest.gtestjs b/chrome/browser/resources/google_now/background_unittest.gtestjs
index 8b902afd1b624afd4976242ceb2e2681ba7b45d0..7cd66f51373fb2a18014299beb5e491494a88642 100644
--- a/chrome/browser/resources/google_now/background_unittest.gtestjs
+++ b/chrome/browser/resources/google_now/background_unittest.gtestjs
@@ -480,8 +480,10 @@ TEST_F(
expectChromeLocalStorageGet(
this, testNotificationDataRequest, testNotificationData);
- this.mockLocalFunctions.expects(once()).selector(undefined).will(
- returnValue(undefined));
+ this.mockLocalFunctions.expects(once())
+ .selector(eqJSON(
+ testNotificationData.notificationsData[testNotificationId]))
+ .will(returnValue(undefined));
// Invoking the tested function.
onNotificationClicked(
@@ -509,8 +511,10 @@ TEST_F(
expectChromeLocalStorageGet(
this, testNotificationDataRequest, testNotificationData);
- this.mockLocalFunctions.expects(once()).selector(testActionUrls).will(
- returnValue(testActionUrl));
+ this.mockLocalFunctions.expects(once())
+ .selector(eqJSON(
+ testNotificationData.notificationsData[testNotificationId]))
+ .will(returnValue(testActionUrl));
var chromeTabsCreateSavedArgs = new SaveMockArguments();
this.mockApis.expects(once()).
instrumented_tabs_create(
@@ -549,8 +553,10 @@ TEST_F(
expectChromeLocalStorageGet(
this, testNotificationDataRequest, testNotificationData);
- this.mockLocalFunctions.expects(once()).selector(testActionUrls).will(
- returnValue(testActionUrl));
+ this.mockLocalFunctions.expects(once())
+ .selector(eqJSON(
+ testNotificationData.notificationsData[testNotificationId]))
+ .will(returnValue(testActionUrl));
var chromeTabsCreateSavedArgs = new SaveMockArguments();
this.mockApis.expects(once()).
instrumented_tabs_create(
« no previous file with comments | « chrome/browser/resources/google_now/background.js ('k') | chrome/browser/resources/google_now/cards.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698