third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp - Issue 2116563003: [DevTools] Report unhandled exceptions and promise rejections through Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp

Issue 2116563003: [DevTools] Report unhandled exceptions and promise rejections through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tests pass Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp ('K') | « third_party/WebKit/Source/core/workers/WorkletGlobalScope.h ('k') | third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp

diff --git a/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp b/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp

index 9a5d5da2329f9c01a68a565af07430bb98231bc5..632f87504e4119823b8f352c1b210b0beeca9205 100644

--- a/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp

+++ b/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp

@@ -69,12 +69,6 @@ void WorkletGlobalScope::reportBlockedScriptExecutionToInspector(const String& d

InspectorInstrumentation::scriptExecutionBlockedByCSP(this, directiveText);

}

-void WorkletGlobalScope::logExceptionToConsole(const String& errorMessage, std::unique_ptr<SourceLocation> location)

- ConsoleMessage* consoleMessage = ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, errorMessage, std::move(location));

- addConsoleMessage(consoleMessage);

KURL WorkletGlobalScope::virtualCompleteURL(const String& url) const

{

// Always return a null URL when passed a null string.