third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp - Issue 2116563003: [DevTools] Report unhandled exceptions and promise rejections through Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp

Issue 2116563003: [DevTools] Report unhandled exceptions and promise rejections through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tests pass Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/Document.cpp ('K') | « third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h ('k') | third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp

diff --git a/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp b/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp

index 6d858ae8c3a9fbb6154c774be0f0abc40d9e4c0b..bd944d5b7a0e8a94665766d50befaa4362d06633 100644

--- a/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp

+++ b/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp

@@ -7,6 +7,7 @@

#include "bindings/core/v8/ScriptSourceCode.h"

#include "bindings/core/v8/WorkerOrWorkletScriptController.h"

#include "core/frame/FrameConsole.h"

+#include "core/inspector/MainThreadDebugger.h"

namespace blink {

@@ -35,4 +36,9 @@ void MainThreadWorkletGlobalScope::addConsoleMessage(ConsoleMessage* consoleMess

frame()->console().addMessage(consoleMessage);

}

+void MainThreadWorkletGlobalScope::logExceptionToConsole(const String& errorMessage, std::unique_ptr<SourceLocation> location)

+ MainThreadDebugger::instance()->exceptionUnhandled(frame(), errorMessage, std::move(location));

kozy 2016/07/08 18:48:59 Is threadDebugger always presented for WorkletGlob

dgozman 2016/07/08 18:56:41 Yes, it's a main thread isolate.

} // namespace blink