third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp - Issue 2116563003: [DevTools] Report unhandled exceptions and promise rejections through Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp

Issue 2116563003: [DevTools] Report unhandled exceptions and promise rejections through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tests pass Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/Document.cpp ('K') | « third_party/WebKit/Source/core/inspector/MainThreadDebugger.h ('k') | third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h » ('j') | third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp

diff --git a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp

index 687ba7ea4e08e5fd507fb48d00b86e54d6c37d5e..ad79801a909db619315e95e7ac1339a8bd879dd7 100644

--- a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp

+++ b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp

@@ -123,6 +123,11 @@ void MainThreadDebugger::contextWillBeDestroyed(ScriptState* scriptState)

debugger()->contextDestroyed(scriptState->context());

}

+void MainThreadDebugger::exceptionUnhandled(LocalFrame* frame, const String& errorMessage, std::unique_ptr<SourceLocation> location)

+ debugger()->exceptionUnhandled(contextGroupId(frame), errorMessage, location->url(), location->lineNumber(), location->columnNumber(), location->cloneStackTrace(), location->scriptId());

int MainThreadDebugger::contextGroupId(LocalFrame* frame)

{

LocalFrame* localFrameRoot = frame->localFrameRoot();