Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2116563003: [DevTools] Report unhandled exceptions and promise rejections through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tests pass Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index 0237c178a90d10d43bb4150ec865e83db8984ccb..c435e5627984bb3b2cfefb9ac0e7a2151f2fbd61 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -175,6 +175,7 @@
#include "core/inspector/InspectorInstrumentation.h"
#include "core/inspector/InspectorTraceEvents.h"
#include "core/inspector/InstanceCounters.h"
+#include "core/inspector/MainThreadDebugger.h"
#include "core/layout/HitTestResult.h"
#include "core/layout/LayoutPart.h"
#include "core/layout/LayoutView.h"
@@ -2893,8 +2894,7 @@ EventTarget* Document::errorEventTarget()
void Document::logExceptionToConsole(const String& errorMessage, std::unique_ptr<SourceLocation> location)
pfeldman 2016/07/07 01:12:17 exeptionThrown
dgozman 2016/07/08 18:56:41 Done.
{
- ConsoleMessage* consoleMessage = ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, errorMessage, std::move(location));
- addConsoleMessage(consoleMessage);
+ MainThreadDebugger::instance()->exceptionUnhandled(m_frame.get(), errorMessage, std::move(location));
}
void Document::setURL(const KURL& url)

Powered by Google App Engine
This is Rietveld 408576698