Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: third_party/WebKit/public/platform/WebDoubleSize.h

Issue 2116283002: Don't let rounding prematurely influence document size when printing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@620456-2
Patch Set: bug 467579 Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebDoubleSize.h
diff --git a/third_party/WebKit/public/platform/WebDoubleSize.h b/third_party/WebKit/public/platform/WebDoubleSize.h
new file mode 100644
index 0000000000000000000000000000000000000000..6042a37f1cfa0c85c47d3a3002c94674bf633cba
--- /dev/null
+++ b/third_party/WebKit/public/platform/WebDoubleSize.h
@@ -0,0 +1,125 @@
+/*
+ * Copyright (C) 2013 Google Inc. All rights reserved.
esprehn 2016/07/22 17:03:09 Wrong year also please use the short copyright all
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef WebDoubleSize_h
+#define WebDoubleSize_h
+
+#include "WebCommon.h"
+
+#include <algorithm>
esprehn 2016/07/22 17:03:08 Why do you need algorithm?
+
+#if INSIDE_BLINK
+#include "platform/geometry/DoubleSize.h"
+#else
+#include <cmath>
esprehn 2016/07/22 17:03:08 Why do you need cmath?
+#include <ui/gfx/geometry/size_f.h>
+#include <ui/gfx/geometry/vector2d_f.h>
+#endif
+
+namespace blink {
+
+struct WebDoubleSize {
esprehn 2016/07/22 17:03:09 class and then put the fields at the bottom
+ double width;
+ double height;
+
+ bool isEmpty() const { return width <= 0 || height <= 0; }
+
+ WebDoubleSize()
+ : width(0)
+ , height(0)
+ {
+ }
+
+ WebDoubleSize(float width, float height)
esprehn 2016/07/22 17:03:09 Why does the constructor not take doubles?
+ : width(width)
+ , height(height)
+ {
+ }
+
+#if INSIDE_BLINK
+ WebDoubleSize(const DoubleSize& s)
+ : width(s.width())
+ , height(s.height())
+ {
+ }
+
+ WebDoubleSize& operator=(const DoubleSize& s)
esprehn 2016/07/22 17:03:09 Don't abbreviate, size
+ {
+ width = s.width();
+ height = s.height();
+ return *this;
+ }
+
+ operator DoubleSize() const
+ {
+ return DoubleSize(width, height);
+ }
+#else
+ WebDoubleSize(const gfx::SizeF& s)
+ : width(s.width())
+ , height(s.height())
+ {
+ }
+
+ WebDoubleSize(const gfx::Vector2dF& v)
+ : width(v.x())
+ , height(v.y())
+ {
+ }
+
+ WebDoubleSize& operator=(const gfx::SizeF& s)
+ {
+ width = s.width();
+ height = s.height();
+ return *this;
+ }
+
+ WebDoubleSize& operator=(const gfx::Vector2dF& v)
+ {
+ width = v.x();
+ height = v.y();
+ return *this;
+ }
+#endif
+};
+
+inline bool operator==(const WebDoubleSize& a, const WebDoubleSize& b)
+{
+ return a.width == b.width && a.height == b.height;
+}
+
+inline bool operator!=(const WebDoubleSize& a, const WebDoubleSize& b)
+{
+ return !(a == b);
+}
+
+} // namespace blink
+
+#endif

Powered by Google App Engine
This is Rietveld 408576698