Don't let rounding prematurely influence document size when printing

third_party/WebKit/public/platform/WebDoubleSize.h

+/*
+ * Copyright (C) 2013 Google Inc. All rights reserved.

[esprehn, 2016/07/22 17:03:09]

Wrong year also please use the short copyright all new files use not this big
one.

+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ *     * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef WebDoubleSize_h
+#define WebDoubleSize_h
+
+#include "WebCommon.h"
+
+#include <algorithm>

[esprehn, 2016/07/22 17:03:08]

Why do you need algorithm?

+
+#if INSIDE_BLINK
+#include "platform/geometry/DoubleSize.h"
+#else
+#include <cmath>

[esprehn, 2016/07/22 17:03:08]

Why do you need cmath?

+#include <ui/gfx/geometry/size_f.h>
+#include <ui/gfx/geometry/vector2d_f.h>
+#endif
+
+namespace blink {
+
+struct WebDoubleSize {

[esprehn, 2016/07/22 17:03:09]

class and then put the fields at the bottom

+    double width;
+    double height;
+
+    bool isEmpty() const { return width <= 0 || height <= 0; }
+
+    WebDoubleSize()
+        : width(0)
+        , height(0)
+    {
+    }
+
+    WebDoubleSize(float width, float height)

[esprehn, 2016/07/22 17:03:09]

Why does the constructor not take doubles?

+        : width(width)
+        , height(height)
+    {
+    }
+
+#if INSIDE_BLINK
+    WebDoubleSize(const DoubleSize& s)
+        : width(s.width())
+        , height(s.height())
+    {
+    }
+
+    WebDoubleSize& operator=(const DoubleSize& s)

[esprehn, 2016/07/22 17:03:09]

Don't abbreviate, size

+    {
+        width = s.width();
+        height = s.height();
+        return *this;
+    }
+
+    operator DoubleSize() const
+    {
+        return DoubleSize(width, height);
+    }
+#else
+    WebDoubleSize(const gfx::SizeF& s)
+        : width(s.width())
+        , height(s.height())
+    {
+    }
+
+    WebDoubleSize(const gfx::Vector2dF& v)
+        : width(v.x())
+        , height(v.y())
+    {
+    }
+
+    WebDoubleSize& operator=(const gfx::SizeF& s)
+    {
+        width = s.width();
+        height = s.height();
+        return *this;
+    }
+
+    WebDoubleSize& operator=(const gfx::Vector2dF& v)
+    {
+        width = v.x();
+        height = v.y();
+        return *this;
+    }
+#endif
+};
+
+inline bool operator==(const WebDoubleSize& a, const WebDoubleSize& b)
+{
+    return a.width == b.width && a.height == b.height;
+}
+
+inline bool operator!=(const WebDoubleSize& a, const WebDoubleSize& b)
+{
+    return !(a == b);
+}
+
+} // namespace blink
+
+#endif