Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1905)

Issue 211623005: aw: Use minimum_accelerated_2d_canvas_size to turn canvas on/off (Closed)

Created:
6 years, 9 months ago by boliu
Modified:
6 years, 9 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

aw: Use minimum_accelerated_2d_canvas_size to turn canvas on/off Always set accelerated_2d_canvas_enabled and use minimum_accelerated_2d_canvas_size to turn canvas on and off. This is a slight abuse but avoids accelerated_2d_canvas_enabled setting also affecting compositing mode in blink BUG=356450 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259504

Patch Set 1 #

Total comments: 1

Patch Set 2 : 100M #

Patch Set 3 : 100M #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M android_webview/native/aw_settings.cc View 1 2 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
boliu
Only need a committer stamp
6 years, 9 months ago (2014-03-25 23:56:32 UTC) #1
aelias_OOO_until_Jul13
https://codereview.chromium.org/211623005/diff/1/android_webview/native/aw_settings.cc File android_webview/native/aw_settings.cc (right): https://codereview.chromium.org/211623005/diff/1/android_webview/native/aw_settings.cc#newcode337 android_webview/native/aw_settings.cc:337: std::numeric_limits<int>::max(); INT_MAX is prone to strange bugs because you ...
6 years, 9 months ago (2014-03-25 23:58:15 UTC) #2
boliu
done
6 years, 9 months ago (2014-03-26 00:03:31 UTC) #3
aelias_OOO_until_Jul13
lgtm
6 years, 9 months ago (2014-03-26 00:04:12 UTC) #4
hush (inactive)
This turns on hardware acceleration for tiny canvas and it seems to be only a ...
6 years, 9 months ago (2014-03-26 00:54:14 UTC) #5
hush (inactive)
lgtm
6 years, 9 months ago (2014-03-26 00:54:24 UTC) #6
boliu
On 2014/03/26 00:54:14, hush wrote: > This turns on hardware acceleration for tiny canvas and ...
6 years, 9 months ago (2014-03-26 00:55:00 UTC) #7
hush (inactive)
On 2014/03/26 00:55:00, boliu wrote: > On 2014/03/26 00:54:14, hush wrote: > > This turns ...
6 years, 9 months ago (2014-03-26 01:00:16 UTC) #8
boliu
On 2014/03/26 00:55:00, boliu wrote: > On 2014/03/26 00:54:14, hush wrote: > > This turns ...
6 years, 9 months ago (2014-03-26 01:00:55 UTC) #9
boliu
The CQ bit was checked by boliu@chromium.org
6 years, 9 months ago (2014-03-26 01:22:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/211623005/110001
6 years, 9 months ago (2014-03-26 01:33:26 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 05:12:14 UTC) #12
Message was sent while issue was closed.
Change committed as 259504

Powered by Google App Engine
This is Rietveld 408576698