build/config/sanitizers/sanitizers.gni - Issue 2116183002: Land chromium-side work to clean up handling of v8_target_cpu in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/sanitizers/sanitizers.gni

Issue 2116183002: Land chromium-side work to clean up handling of v8_target_cpu in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix missing import Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/sanitizers/sanitizers.gni

diff --git a/build/config/sanitizers/sanitizers.gni b/build/config/sanitizers/sanitizers.gni

index c58e72f668d128ee632bb1d56f704829f9776041..a7a9707c49e1820b10377db961721aa67d6ac876 100644

--- a/build/config/sanitizers/sanitizers.gni

+++ b/build/config/sanitizers/sanitizers.gni

@@ -142,3 +142,6 @@ prebuilt_instrumented_libraries_available =

# For one-off testing, just comment this assertion out.

assert(!is_debug || !(is_msan || is_ubsan || is_ubsan_null || is_ubsan_vptr),

"Sanitizers should generally be used in release (set is_debug=false).")

+assert(!is_msan || (is_linux && current_cpu == "x64"),

+ "MSan currently only works on 64-bit Linux and ChromeOS builds.")

« no previous file with comments | « build/config/mips.gni ('k') | build/config/v8_target_cpu.gni » ('j') | no next file with comments »