Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: build/config/sanitizers/sanitizers.gni

Issue 2116183002: Land chromium-side work to clean up handling of v8_target_cpu in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix missing import Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/mips.gni ('k') | build/config/v8_target_cpu.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 declare_args() { 5 declare_args() {
6 # Compile for Address Sanitizer to find memory bugs. 6 # Compile for Address Sanitizer to find memory bugs.
7 is_asan = false 7 is_asan = false
8 8
9 # Compile for Leak Sanitizer to find leaks. 9 # Compile for Leak Sanitizer to find leaks.
10 is_lsan = false 10 is_lsan = false
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 # 135 #
136 # If you find a use-case where you want to compile a sanitizer in debug mode 136 # If you find a use-case where you want to compile a sanitizer in debug mode
137 # and have verified it works, ask brettw and we can consider removing it from 137 # and have verified it works, ask brettw and we can consider removing it from
138 # this condition. We may also be able to find another way to enable your case 138 # this condition. We may also be able to find another way to enable your case
139 # without having people accidentally get broken builds by compiling an 139 # without having people accidentally get broken builds by compiling an
140 # unsupported or unadvisable configurations. 140 # unsupported or unadvisable configurations.
141 # 141 #
142 # For one-off testing, just comment this assertion out. 142 # For one-off testing, just comment this assertion out.
143 assert(!is_debug || !(is_msan || is_ubsan || is_ubsan_null || is_ubsan_vptr), 143 assert(!is_debug || !(is_msan || is_ubsan || is_ubsan_null || is_ubsan_vptr),
144 "Sanitizers should generally be used in release (set is_debug=false).") 144 "Sanitizers should generally be used in release (set is_debug=false).")
145
146 assert(!is_msan || (is_linux && current_cpu == "x64"),
147 "MSan currently only works on 64-bit Linux and ChromeOS builds.")
OLDNEW
« no previous file with comments | « build/config/mips.gni ('k') | build/config/v8_target_cpu.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698