mac: Use instantiateWithOwner: instead of deprecated instantiateNibWithOwner:

mac: Use instantiateWithOwner: instead of deprecated instantiateNibWithOwner:

The old API used to retain all objects in the nib.  The new one doesn't, so
do that manually.

No behavior change.

Similar to https://codereview.chromium.org/1836363002/

BUG=622481
TBR=avi

Committed: https://crrev.com/17c246d15c8729f54ca480a9f256b8d31d39c90a
Cr-Commit-Position: refs/heads/master@{#403550}

[Nico, 2016-07-01 21:45:09]

thakis@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2016-07-01 21:50:39]

LGTM

https://codereview.chromium.org/2116103002/diff/60001/chrome/browser/chrome_b...
File chrome/browser/chrome_browser_main_mac.mm (right):

https://codereview.chromium.org/2116103002/diff/60001/chrome/browser/chrome_b...
chrome/browser/chrome_browser_main_mac.mm:155: for (NSObject* object :
top_level_objects)
Convenience function to instantiate the nib and retain the top-level objects?

It’s probably not worth it with two callers, but I think it’d become more
attractive at three or more.

[Nico, 2016-07-01 21:53:56]

thanks!

https://codereview.chromium.org/2116103002/diff/60001/chrome/browser/chrome_b...
File chrome/browser/chrome_browser_main_mac.mm (right):

https://codereview.chromium.org/2116103002/diff/60001/chrome/browser/chrome_b...
chrome/browser/chrome_browser_main_mac.mm:155: for (NSObject* object :
top_level_objects)
On 2016/07/01 21:50:39, Mark Mentovai wrote:
> Convenience function to instantiate the nib and retain the top-level objects?
> 
> It’s probably not worth it with two callers, but I think it’d become more
> attractive at three or more.

I agree :-)

I think it'd be even nicer if the File's Owner had strong references to these
objects and then we wouldn't have to retain them (but that requires modifying
xib files, which is, as rsesek put it, "improbable").

[Nico, 2016-07-01 21:54:00]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-07-01 21:54:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 22:02:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 22:02:42]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2016-07-01 22:03:39]

Description was changed from

==========
mac: Use instantiateWithOwner: instead of deprecated instantiateNibWithOwner:

The old API used to retain all objects in the nib.  The new one doesn't, so
do that manually.

No behavior change.

Similar to https://codereview.chromium.org/1836363002/

BUG=622481
==========

to

==========
mac: Use instantiateWithOwner: instead of deprecated instantiateNibWithOwner:

The old API used to retain all objects in the nib.  The new one doesn't, so
do that manually.

No behavior change.

Similar to https://codereview.chromium.org/1836363002/

BUG=622481
TBR=avi
==========

[Nico, 2016-07-01 22:03:52]

thakis@chromium.org changed reviewers:
+ avi@chromium.org

[Nico, 2016-07-01 22:03:53]

tbr avi for content/owners

[Nico, 2016-07-01 22:04:04]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-07-01 22:04:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-07-01 22:23:54]

LGTM in any case.

https://codereview.chromium.org/2116103002/diff/60001/content/shell/browser/s...
File content/shell/browser/shell_browser_main_parts_mac.mm (right):

https://codereview.chromium.org/2116103002/diff/60001/content/shell/browser/s...
content/shell/browser/shell_browser_main_parts_mac.mm:26: [object retain];
Is

[top_level_objects makeObjectsPerformSelector:@selector(retain)];

too baroque? :)

[commit-bot: I haz the power, 2016-07-01 22:28:23]

Description was changed from

==========
mac: Use instantiateWithOwner: instead of deprecated instantiateNibWithOwner:

The old API used to retain all objects in the nib.  The new one doesn't, so
do that manually.

No behavior change.

Similar to https://codereview.chromium.org/1836363002/

BUG=622481
TBR=avi
==========

to

==========
mac: Use instantiateWithOwner: instead of deprecated instantiateNibWithOwner:

The old API used to retain all objects in the nib.  The new one doesn't, so
do that manually.

No behavior change.

Similar to https://codereview.chromium.org/1836363002/

BUG=622481
TBR=avi
==========

[commit-bot: I haz the power, 2016-07-01 22:28:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-01 22:30:08]

Description was changed from

==========
mac: Use instantiateWithOwner: instead of deprecated instantiateNibWithOwner:

The old API used to retain all objects in the nib.  The new one doesn't, so
do that manually.

No behavior change.

Similar to https://codereview.chromium.org/1836363002/

BUG=622481
TBR=avi
==========

to

==========
mac: Use instantiateWithOwner: instead of deprecated instantiateNibWithOwner:

The old API used to retain all objects in the nib.  The new one doesn't, so
do that manually.

No behavior change.

Similar to https://codereview.chromium.org/1836363002/

BUG=622481
TBR=avi

Committed: https://crrev.com/17c246d15c8729f54ca480a9f256b8d31d39c90a
Cr-Commit-Position: refs/heads/master@{#403550}
==========

[commit-bot: I haz the power, 2016-07-01 22:30:10]

Patchset 4 (id:??) landed as
https://crrev.com/17c246d15c8729f54ca480a9f256b8d31d39c90a
Cr-Commit-Position: refs/heads/master@{#403550}