mac: Use instantiateWithOwner: instead of deprecated instantiateNibWithOwner:

chrome/browser/chrome_browser_main_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main_mac.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/mac/bundle_locations.h"
 #import "base/mac/foundation_util.h"
 #include "base/mac/mac_util.h"
 #include "base/mac/scoped_nsobject.h"
+#include "base/mac/sdk_forward_declarations.h"
 #include "base/path_service.h"
 #include "base/threading/thread_task_runner_handle.h"
 #import "chrome/browser/app_controller_mac.h"
 #include "chrome/browser/apps/app_shim/app_shim_host_manager_mac.h"
 #include "chrome/browser/browser_process.h"
 #import "chrome/browser/chrome_browser_application_mac.h"
 #include "chrome/browser/mac/install_from_dmg.h"
 #import "chrome/browser/mac/keystone_glue.h"
 #include "chrome/browser/mac/mac_startup_profiler.h"
 #include "chrome/browser/ui/app_list/app_list_service.h"
@@ skipping 116 matching lines @@
       exit(0);
     }
   }
 
   // Now load the nib (from the right bundle).
   base::scoped_nsobject<NSNib> nib(
       [[NSNib alloc] initWithNibNamed:@"MainMenu"
                                bundle:base::mac::FrameworkBundle()]);
   // TODO(viettrungluu): crbug.com/20504 - This currently leaks, so if you
   // change this, you'll probably need to change the Valgrind suppression.
-  [nib instantiateNibWithOwner:NSApp topLevelObjects:nil];
+  NSArray* top_level_objects = nil;
+  [nib instantiateWithOwner:NSApp topLevelObjects:&top_level_objects];
+  for (NSObject* object : top_level_objects)

[Mark Mentovai, 2016/07/01 21:50:39]

Convenience function to instantiate the nib and retain the top-level objects?

It’s probably not worth it with two callers, but I think it’d become more
attractive at three or more.

[Nico, 2016/07/01 21:53:56]

I agree :-)

I think it'd be even nicer if the File's Owner had strong references to these
objects and then we wouldn't have to retain them (but that requires modifying
xib files, which is, as rsesek put it, "improbable").

+    [object retain];
   // Make sure the app controller has been created.
   DCHECK([NSApp delegate]);
 
   [[NSUserDefaults standardUserDefaults] registerDefaults:@{
       // Prevent Cocoa from turning command-line arguments into
       // |-application:openFiles:|, since we already handle them directly.
       // @"NO" looks like a mistake, but the value really is supposed to be a
       // string.
       @"NSTreatUnknownArgumentsAsOpen": @"NO"
   }];
@@ skipping 39 matching lines @@
     [glue updateProfileCountsWithNumProfiles:0
                          numSignedInProfiles:0];
   }
 }
 
 void ChromeBrowserMainPartsMac::DidEndMainMessageLoop() {
   AppController* appController =
       base::mac::ObjCCastStrict<AppController>([NSApp delegate]);
   [appController didEndMainMessageLoop];
 }