Chromium Code Reviews Chromium Code Reviews
Issue 2116073002:
[Findit] Fix redirect bug and update template for waterfall/culprit. (Closed)
Base URL: https://chromium.googlesource.com/infra/infra.git@master| Index: appengine/findit/templates/waterfall/culprit.html |
| diff --git a/appengine/findit/templates/waterfall/culprit.html b/appengine/findit/templates/waterfall/culprit.html |
| index 62562342870ae26629915faa043204d1edf3d48b..0c025b75f095acd6311eb327f0661bcb9f515dc3 100644 |
| --- a/appengine/findit/templates/waterfall/culprit.html |
| +++ b/appengine/findit/templates/waterfall/culprit.html |
| @@ -7,7 +7,7 @@ |
| <body> |
| <h1>Culprit</h1> |
| <b>Project:</b> {{project_name}}<br> |
| - <b>Revision:</b><a href="https://crrev.com/{{revision}}">{{revision}}</a><br> |
| + <b>Commit:</b> <a href="https://crrev.com/{{commit_position or revision}}">{{commit_position or revision}}</a><br> |
| {% if cr_notified %} |
| <b>Notified:</b> Yes<br> |
| <b>Notification time:</b> {{cr_notification_time}}<br> |
| @@ -23,6 +23,7 @@ |
| <th>Master</th> |
| <th>Builder</th> |
| <th>Build Number</th> |
| + <th>Findit Result</th> |
| </thead> |
| <tbody> |
| {% for build in builds %} |
| @@ -31,15 +32,20 @@ |
| <td>{{build.master_name}}</td> |
| <td>{{build.builder_name}}</td> |
| <td> |
| - <a href="/waterfall/build-failure?url=https://build.chromium.org/p |
| -/{{build.master_name}}/builders/{{build.builder_name}} |
| -/builds/{{build.build_number}}"> |
| + <a href="https://build.chromium.org/p/{{build.master_name}}/builders/{{build.builder_name}}/builds/{{build.build_number}}"> |
| {{build.build_number}} |
| </a> |
| </td> |
| + <td> |
| + <a href="/waterfall/build-failure?url=https://build.chromium.org/p/{{build.master_name}}/builders/{{build.builder_name}}/builds/{{build.build_number}}"> |
| + Analysis |
|
chanli
2016/07/01 20:17:36
nit: Since the header is 'Findit Result', I'm not
stgao
2016/07/01 22:47:30
After a second thought, this link seems not useful
|
| + </a> |
| + </td> |
| </tr> |
| {% endfor %} |
| </tbody> |
| </table> |
| </div> |
| + <br> |
| + <a href="https://bugs.chromium.org/p/chromium/issues/entry?status=Available&labels=findit-for-waterfall&components=Tools>Test>Findit>WrongResult&summary=Wrong Findit result for {{commit_position or revision}}&comment=Detail is https://findit-for-me.appspot.com/waterfall/culprit?key={{key}}&cc=stgao@chromium.org,chanli@chromium.org,lijeffrey@chromium.org">File a bug for wrong Findit result!</a> |
| </body> |
