Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 2116023002: MD Settings: Search engines dropdown, tweak focus/hover behavior. (Closed)

Created:
4 years, 5 months ago by dpapad
Modified:
4 years, 5 months ago
Reviewers:
michaelpg
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Search engines dropdown, tweak focus/hover behavior. Specifically removing hover effects, adding missing focus effect. BUG=621444 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/4d8e2d9c3a4e495f4df013cad9ab35cb7c3b068e Cr-Commit-Position: refs/heads/master@{#403811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M chrome/browser/resources/settings/search_page/search_page.html View 3 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dpapad
4 years, 5 months ago (2016-07-01 19:08:38 UTC) #3
michaelpg
lgtm
4 years, 5 months ago (2016-07-04 17:48:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116023002/1
4 years, 5 months ago (2016-07-05 18:16:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 18:50:38 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-05 18:50:44 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 18:52:11 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d8e2d9c3a4e495f4df013cad9ab35cb7c3b068e
Cr-Commit-Position: refs/heads/master@{#403811}

Powered by Google App Engine
This is Rietveld 408576698