Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4729)

Unified Diff: chrome/browser/resources/settings/search_page/search_page.html

Issue 2116023002: MD Settings: Search engines dropdown, tweak focus/hover behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/search_page/search_page.html
diff --git a/chrome/browser/resources/settings/search_page/search_page.html b/chrome/browser/resources/settings/search_page/search_page.html
index 4062d3bfef428470c0f55274cce90aead2e420db..eb12862a651933f6ed9e2680aa3654cbdef03b25 100644
--- a/chrome/browser/resources/settings/search_page/search_page.html
+++ b/chrome/browser/resources/settings/search_page/search_page.html
@@ -19,12 +19,11 @@
paper-listbox div {
align-items: center;
+ color: var(--paper-grey-800);
display: flex;
- font-size: 16px;
- font-weight: 400;
- line-height: 24px;
+ font-size: inherit;
min-height: 48px;
- padding: 0px 16px;
+ padding: 0 16px;
}
paper-listbox div.iron-selected {
@@ -32,12 +31,9 @@
}
paper-listbox div:focus {
+ background-color: var(--paper-grey-300);
outline: none;
}
-
- paper-listbox div:hover {
- background-color: var(--settings-hover-color);
- }
</style>
<settings-animated-pages id="pages" current-route="{{currentRoute}}"
section="search">
@@ -49,7 +45,9 @@
selected="[[getSelectedSearchEngineIndex_(searchEngines_)]]"
on-iron-select="onIronSelect_">
<template is="dom-repeat" items="[[searchEngines_]]">
- <div>[[item.name]]</div>
+ <!--TODO(dpapad): Use <button class="paper-item">..</button>
+ once it lands in paper-item-shared-styles.html-->
+ <div role="option">[[item.name]]</div>
</template>
</paper-listbox>
</paper-dropdown-menu>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698