Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2115953002: bluetooth: Initialize start_notitications_in_progress_ (Closed)

Created:
4 years, 5 months ago by ortuno
Modified:
4 years, 5 months ago
Reviewers:
jlebel
CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Initialize start_notitications_in_progress_ This was causing StartNotifySession to hang randomly. Also adds some logging to make sure we know what's happening. BUG=624745 Committed: https://crrev.com/7a941f9dd60b02e7b886b2774244ac5b04f1bf37 Cr-Commit-Position: refs/heads/master@{#403831}

Patch Set 1 #

Patch Set 2 : Clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm View 1 4 chunks +10 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1941923002 Patch 300001

Messages

Total messages: 12 (5 generated)
ortuno
jlebel: PTAL
4 years, 5 months ago (2016-07-01 16:43:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115953002/20001
4 years, 5 months ago (2016-07-01 16:43:37 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-01 17:53:35 UTC) #6
jlebel
lgtm
4 years, 5 months ago (2016-07-04 08:54:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115953002/20001
4 years, 5 months ago (2016-07-05 22:50:23 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-06 00:07:19 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 00:09:12 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7a941f9dd60b02e7b886b2774244ac5b04f1bf37
Cr-Commit-Position: refs/heads/master@{#403831}

Powered by Google App Engine
This is Rietveld 408576698