Convert video-controls* tests to testharness.js

Convert video-controls* tests to testharness.js

Cleaning up video-controls* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/029e9b258d6a9f685f389054588d9f2cfb1ac9b0
Cr-Commit-Position: refs/heads/master@{#403434}

[Srirama, 2016-07-01 07:49:59]

Description was changed from

==========
fix

BUG=
==========

to

==========
Convert video-controls* tests to testharness.js

Cleaning up video-controls* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-07-01 07:50:59]

srirama.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Srirama, 2016-07-01 07:51:01]

PTAL

[fs, 2016-07-01 09:21:22]

LGTM w/ nits

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-controls-transformed.html
(right):

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-controls-transformed.html:17:
assert_not_equals(video.controls, null);
assert_true

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-controls-zoomed.html (right):

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-controls-zoomed.html:16:
assert_not_equals(video.controls, null);
Ditto

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-controls.html (right):

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-controls.html:10:
assert_not_equals(video.controls, null);
'controls' is a boolean attribute, so assert_true would seem more to the point
here (and similarly below.)

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-controls.html:19:
assert_false(video.controls, false);
Nit: Drop second arg (false is a poor description ;-))

[Srirama, 2016-07-01 09:34:04]

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-controls-transformed.html
(right):

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-controls-transformed.html:17:
assert_not_equals(video.controls, null);
On 2016/07/01 09:21:22, fs wrote:
> assert_true

Done.

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-controls-zoomed.html (right):

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-controls-zoomed.html:16:
assert_not_equals(video.controls, null);
On 2016/07/01 09:21:22, fs wrote:
> Ditto

Done.

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-controls.html (right):

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-controls.html:10:
assert_not_equals(video.controls, null);
On 2016/07/01 09:21:22, fs wrote:
> 'controls' is a boolean attribute, so assert_true would seem more to the point
> here (and similarly below.)

Done.

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-controls.html:19:
assert_false(video.controls, false);
On 2016/07/01 09:21:22, fs wrote:
> Nit: Drop second arg (false is a poor description ;-))

Done.

[Srirama, 2016-07-01 09:34:37]

The CQ bit was checked by srirama.m@samsung.com

[Srirama, 2016-07-01 09:34:37]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2115833002/#ps20001
(title: "address nits")

[commit-bot: I haz the power, 2016-07-01 09:34:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 10:42:53]

Description was changed from

==========
Convert video-controls* tests to testharness.js

Cleaning up video-controls* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-controls* tests to testharness.js

Cleaning up video-controls* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[commit-bot: I haz the power, 2016-07-01 10:42:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-01 10:42:56]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-01 10:45:01]

Description was changed from

==========
Convert video-controls* tests to testharness.js

Cleaning up video-controls* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-controls* tests to testharness.js

Cleaning up video-controls* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/029e9b258d6a9f685f389054588d9f2cfb1ac9b0
Cr-Commit-Position: refs/heads/master@{#403434}
==========

[commit-bot: I haz the power, 2016-07-01 10:45:02]

Patchset 2 (id:??) landed as
https://crrev.com/029e9b258d6a9f685f389054588d9f2cfb1ac9b0
Cr-Commit-Position: refs/heads/master@{#403434}