Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Issue 2115833002: Convert video-controls* tests to testharness.js (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-controls* tests to testharness.js Cleaning up video-controls* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/029e9b258d6a9f685f389054588d9f2cfb1ac9b0 Cr-Commit-Position: refs/heads/master@{#403434}

Patch Set 1 #

Total comments: 8

Patch Set 2 : address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -152 lines) Patch
M third_party/WebKit/LayoutTests/media/video-controls.html View 1 1 chunk +23 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-controls-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-controls-transformed.html View 1 1 chunk +30 lines, -44 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-controls-transformed-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-controls-zoomed.html View 1 1 chunk +33 lines, -56 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-controls-zoomed-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Srirama
PTAL
4 years, 5 months ago (2016-07-01 07:51:01 UTC) #3
fs
LGTM w/ nits https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTests/media/video-controls-transformed.html File third_party/WebKit/LayoutTests/media/video-controls-transformed.html (right): https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTests/media/video-controls-transformed.html#newcode17 third_party/WebKit/LayoutTests/media/video-controls-transformed.html:17: assert_not_equals(video.controls, null); assert_true https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTests/media/video-controls-zoomed.html File third_party/WebKit/LayoutTests/media/video-controls-zoomed.html ...
4 years, 5 months ago (2016-07-01 09:21:22 UTC) #4
Srirama
https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTests/media/video-controls-transformed.html File third_party/WebKit/LayoutTests/media/video-controls-transformed.html (right): https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTests/media/video-controls-transformed.html#newcode17 third_party/WebKit/LayoutTests/media/video-controls-transformed.html:17: assert_not_equals(video.controls, null); On 2016/07/01 09:21:22, fs wrote: > assert_true ...
4 years, 5 months ago (2016-07-01 09:34:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115833002/20001
4 years, 5 months ago (2016-07-01 09:34:48 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-01 10:42:54 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 10:42:56 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 10:45:02 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/029e9b258d6a9f685f389054588d9f2cfb1ac9b0
Cr-Commit-Position: refs/heads/master@{#403434}

Powered by Google App Engine
This is Rietveld 408576698