third_party/WebKit/LayoutTests/media/video-controls.html - Issue 2115833002: Convert video-controls* tests to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-controls.html

Issue 2115833002: Convert video-controls* tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/video-controls-expected.txt » ('j') | third_party/WebKit/LayoutTests/media/video-controls-transformed.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	1 <!DOCTYPE html>

	2 <title>Test "controls" attribute.</title>

	3 <script src="../resources/testharness.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <script src="media-file.js"></script>

1 <video controls></video>	6 <video controls></video>

2 <p>Test 'controls' attribute<p>

3 <script src=media-file.js></script>

4 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

5 (Please avoid writing new tests using video-test.js) -->

6 <script src=video-test.js></script>

7 <script>	7 <script>

8 testExpected("video.controls", null, '!=');	8 async_test(function(t) {

9 waitForEvent('canplaythrough', function () {	9 var video = document.querySelector("video");

10 testExpected("video.controls", null, '!=');	10 assert_not_equals(video.controls, null);
	fs 2016/07/01 09:21:22 'controls' is a boolean attribute, so assert_true 'controls' is a boolean attribute, so assert_true would seem more to the point here (and similarly below.) Srirama 2016/07/01 09:34:04 Done. Show quoted text On 2016/07/01 09:21:22, fs wrote: > 'controls' is a boolean attribute, so assert_true would seem more to the point > here (and similarly below.) Done.
11 run("video.removeAttribute('controls')");	11

12 testExpected("video.controls", false, '==');	12 video.oncanplaythrough = t.step_func_done(function() {

13 run("video.controls = true");	13 assert_not_equals(video.controls, null);

14 testExpected("video.getAttribute('controls')", "");	14 video.removeAttribute("controls");

15 run("video.controls = false");	15 assert_false(video.controls);

16 testExpected("video.controls", false, '==');	16 video.controls = true;

17 run("video.setAttribute('controls','controls')");	17 assert_equals(video.getAttribute("controls"), "");

18 testExpected("video.controls", null, '!=');	18 video.controls = false;

19 endTest();	19 assert_false(video.controls, false);
	fs 2016/07/01 09:21:22 Nit: Drop second arg (false is a poor description Nit: Drop second arg (false is a poor description ;-)) Srirama 2016/07/01 09:34:04 Done. Show quoted text On 2016/07/01 09:21:22, fs wrote: > Nit: Drop second arg (false is a poor description ;-)) Done.
20 } );	20 video.setAttribute("controls", "controls");

	21 assert_not_equals(video.controls, null);

	22 });

	23

21 video.src = findMediaFile("video", "content/test");	24 video.src = findMediaFile("video", "content/test");

22 </script>	25 });

	26 </script>

OLD	NEW