Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2115673002: Remove unneeded helpers in AA and non-AA rect GrBatch subclasses (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@rectgeoms2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove unneeded helpers in AA and non-AA rect GrBatch subclasses. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2115673002 Committed: https://skia.googlesource.com/skia/+/bc9b6a4239b797fe7fbdb876607053b18eba2380

Patch Set 1 #

Patch Set 2 : minor #

Patch Set 3 : Include non aa rect batch classes #

Patch Set 4 : Add back \n to debug print #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -305 lines) Patch
M src/gpu/batches/GrAAFillRectBatch.cpp View 1 2 3 10 chunks +50 lines, -159 lines 0 comments Download
M src/gpu/batches/GrNonAAFillRectBatch.cpp View 1 2 10 chunks +47 lines, -146 lines 0 comments Download

Dependent Patchsets:

Issue 2116723003 Patch 1

Messages

Total messages: 19 (10 generated)
bsalomon
4 years, 5 months ago (2016-06-30 20:22:02 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115673002/20001
4 years, 5 months ago (2016-06-30 21:15:28 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 22:01:26 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115673002/40001
4 years, 5 months ago (2016-07-01 02:59:04 UTC) #10
robertphillips
lgtm
4 years, 5 months ago (2016-07-01 12:12:25 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115673002/60001
4 years, 5 months ago (2016-07-01 12:12:38 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-01 12:26:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115673002/60001
4 years, 5 months ago (2016-07-01 12:34:57 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 12:35:56 UTC) #19
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/bc9b6a4239b797fe7fbdb876607053b18eba2380

Powered by Google App Engine
This is Rietveld 408576698