Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2115613002: Fix CustomTabs.ClientAppId counting. (Closed)

Created:
4 years, 5 months ago by Ted C
Modified:
4 years, 5 months ago
Reviewers:
Maria
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix CustomTabs.ClientAppId counting. Prior to this, the client ID was being counted on initial startup as well as any cold start refocuses of the CustomTabs. This moves the tracking to match StartedInitially which checks for the existence of getSavedInstanceState() BUG=622366 Committed: https://crrev.com/522575f82799dbf24ad928f9dbe14250673e11fa Cr-Commit-Position: refs/heads/master@{#403220}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Ted C
PTAL
4 years, 5 months ago (2016-06-30 17:00:11 UTC) #2
Maria
lgtm
4 years, 5 months ago (2016-06-30 17:14:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115613002/1
4 years, 5 months ago (2016-06-30 17:17:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/29723)
4 years, 5 months ago (2016-06-30 17:22:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115613002/1
4 years, 5 months ago (2016-06-30 17:55:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 18:03:22 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 18:05:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/522575f82799dbf24ad928f9dbe14250673e11fa
Cr-Commit-Position: refs/heads/master@{#403220}

Powered by Google App Engine
This is Rietveld 408576698