Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

Issue 2115613002: Fix CustomTabs.ClientAppId counting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
index 9f29e9a13ace3c9a17820e1ea45f468b76dc7ee1..a7445bf843a06454a023a6e6639bd3b84b66e364 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
@@ -90,7 +90,6 @@ public class CustomTabActivity extends ChromeActivity {
// change the package name.
private boolean mShouldOverridePackage;
- private boolean mRecordedStartupUma;
private boolean mHasCreatedTabEarly;
private boolean mIsInitialStart = true;
private boolean mHasPrerender;
@@ -425,17 +424,14 @@ public class CustomTabActivity extends ChromeActivity {
super.onStartWithNative();
setActiveContentHandler(mCustomTabContentHandler);
- if (!mRecordedStartupUma) {
- mRecordedStartupUma = true;
+ if (getSavedInstanceState() != null || !mIsInitialStart) {
+ RecordUserAction.record("CustomTabs.StartedReopened");
+ } else {
ExternalAppId externalId =
IntentHandler.determineExternalIntentSource(getPackageName(), getIntent());
RecordHistogram.recordEnumeratedHistogram("CustomTabs.ClientAppId",
externalId.ordinal(), ExternalAppId.INDEX_BOUNDARY.ordinal());
- }
- if (getSavedInstanceState() != null || !mIsInitialStart) {
- RecordUserAction.record("CustomTabs.StartedReopened");
- } else {
RecordUserAction.record("CustomTabs.StartedInitially");
}
mIsInitialStart = false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698