chrome/browser/ui/views/website_settings/permissions_bubble_view.h - Issue 2115433002: Ensure permission bubble is stacked below the exclusive access bubble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/permissions_bubble_view.h

Issue 2115433002: Ensure permission bubble is stacked below the exclusive access bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-bubble-detach-from-fullscreen

Patch Set: Fix Mac compile. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/exclusive_access_bubble_views.h ('k') | chrome/browser/ui/views/website_settings/permissions_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/permissions_bubble_view.h

diff --git a/chrome/browser/ui/views/website_settings/permissions_bubble_view.h b/chrome/browser/ui/views/website_settings/permissions_bubble_view.h

index bc839fd176290f95d74b26fcc1227745c1fb306e..8e05d65c44c55e4d3c53e55a53191c307ce44b78 100644

--- a/chrome/browser/ui/views/website_settings/permissions_bubble_view.h

+++ b/chrome/browser/ui/views/website_settings/permissions_bubble_view.h

@@ -12,6 +12,7 @@

#include "base/macros.h"

#include "chrome/browser/ui/website_settings/permission_bubble_view.h"

#include "ui/gfx/geometry/point.h"

+#include "ui/gfx/native_widget_types.h"

#include "ui/views/bubble/bubble_border.h"

namespace views {

@@ -42,11 +43,12 @@ class PermissionBubbleViewViews : public PermissionBubbleView {

void Deny();

private:

- // These three functions have separate implementations for Views-based and

+ // These four methods have separate implementations for Views-based and

// Cocoa-based browsers, to allow this bubble to be used in either.

views::View* GetAnchorView();

gfx::Point GetAnchorPoint();

views::BubbleBorder::Arrow GetAnchorArrow();

+ gfx::NativeView GetExclusiveAccessNativeView();

Browser* browser_;

Delegate* delegate_;