chrome/browser/ui/views/website_settings/permissions_bubble_view.cc - Issue 2115433002: Ensure permission bubble is stacked below the exclusive access bubble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

Issue 2115433002: Ensure permission bubble is stacked below the exclusive access bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-bubble-detach-from-fullscreen

Patch Set: Fix Mac compile. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/website_settings/permissions_bubble_view.h ('k') | chrome/browser/ui/views/website_settings/permissions_bubble_view_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

diff --git a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

index 066900f7696c87c5e564b12879387c617e661c27..a54f86461619643ec622142627317c9142c03f85 100644

--- a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

+++ b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

@@ -405,6 +405,11 @@ void PermissionBubbleViewViews::Show(

bubble_delegate_->UpdateAnchor(GetAnchorView(),

GetAnchorPoint(),

GetAnchorArrow());

+ // Ensure this view does not cover over the exclusive access bubble.

+ gfx::NativeView exclusive_access_native_view = GetExclusiveAccessNativeView();

+ if (exclusive_access_native_view)

+ bubble_delegate_->GetWidget()->StackBelow(exclusive_access_native_view);

}

bool PermissionBubbleViewViews::CanAcceptRequestUpdate() {