Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2115263002: Restore GTM Foundation/GTMIBArray.m to the build (Closed)

Created:
4 years, 5 months ago by Mark Mentovai
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Restore GTM Foundation/GTMIBArray.m to the build c23cd73367a4 removed this file from the build under the premise that it was unused, but it's actually referenced by chrome/app/nibs/FirstRunDialog.xib. BUG=624850 TEST=Run an official build with a new --user-data-dir, get first run UI Review-Url: https://codereview.chromium.org/2114123002 Cr-Commit-Position: refs/heads/master@{#403507} (cherry picked from commit 8262005142234430a1879764a9d84bf26b599661) Committed: https://chromium.googlesource.com/chromium/src/+/370f1caeb3c2b09b3e9afd5388948a3b4c6466e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/google_toolbox_for_mac/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Mark Mentovai
4 years, 5 months ago (2016-07-02 21:47:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
370f1caeb3c2b09b3e9afd5388948a3b4c6466e6.

Powered by Google App Engine
This is Rietveld 408576698