Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1957)

Issue 2114123002: Restore GTM Foundation/GTMIBArray.m to the build (Closed)

Created:
4 years, 5 months ago by Mark Mentovai
Modified:
4 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore GTM Foundation/GTMIBArray.m to the build c23cd73367a4 removed this file from the build under the premise that it was unused, but it's actually referenced by chrome/app/nibs/FirstRunDialog.xib. BUG=624850 TEST=Run an official build with a new --user-data-dir, get first run UI Committed: https://crrev.com/8262005142234430a1879764a9d84bf26b599661 Cr-Commit-Position: refs/heads/master@{#403507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/google_toolbox_for_mac/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Mark Mentovai
4 years, 5 months ago (2016-07-01 19:03:52 UTC) #2
Nico
lgtm Thanks much for fixing. I checked that this is the only file referenced from ...
4 years, 5 months ago (2016-07-01 19:40:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114123002/1
4 years, 5 months ago (2016-07-01 19:42:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 20:05:50 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 20:08:23 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8262005142234430a1879764a9d84bf26b599661
Cr-Commit-Position: refs/heads/master@{#403507}

Powered by Google App Engine
This is Rietveld 408576698