Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Unified Diff: Source/platform/graphics/filters/FEDropShadow.cpp

Issue 211513003: Returning IntSize to store calculated kernel size values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/graphics/filters/FEDropShadow.cpp
diff --git a/Source/platform/graphics/filters/FEDropShadow.cpp b/Source/platform/graphics/filters/FEDropShadow.cpp
index b8e2ebddf308607848e21d5860f96dd86e88ee94..e73e29786329a81ea2b691a44e86ad23369e1b70 100644
--- a/Source/platform/graphics/filters/FEDropShadow.cpp
+++ b/Source/platform/graphics/filters/FEDropShadow.cpp
@@ -62,13 +62,12 @@ FloatRect FEDropShadow::mapRect(const FloatRect& rect, bool forward)
offsetRect.move(-filter->applyHorizontalScale(m_dx), -filter->applyVerticalScale(m_dy));
result.unite(offsetRect);
- unsigned kernelSizeX = 0;
- unsigned kernelSizeY = 0;
- FEGaussianBlur::calculateKernelSize(filter, kernelSizeX, kernelSizeY, m_stdX, m_stdY);
+ IntSize kernelSize(0, 0);
pdr. 2014/03/26 00:00:13 Is this needed?
Savago 2014/03/26 00:12:24 Just checked IntSize() and it already initializes
+ kernelSize = FEGaussianBlur::calculateKernelSize(filter, m_stdX, m_stdY);
// We take the half kernel size and multiply it with three, because we run box blur three times.
- result.inflateX(3 * kernelSizeX * 0.5f);
- result.inflateY(3 * kernelSizeY * 0.5f);
+ result.inflateX(3 * kernelSize.width() * 0.5f);
+ result.inflateY(3 * kernelSize.height() * 0.5f);
return result;
}
« no previous file with comments | « no previous file | Source/platform/graphics/filters/FEGaussianBlur.h » ('j') | Source/platform/graphics/filters/FEGaussianBlur.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698