Source/platform/graphics/filters/FEGaussianBlur.h - Issue 211513003: Returning IntSize to store calculated kernel size values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/filters/FEGaussianBlur.h

Issue 211513003: Returning IntSize to store calculated kernel size values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/graphics/filters/FEDropShadow.cpp ('K') | « Source/platform/graphics/filters/FEDropShadow.cpp ('k') | Source/platform/graphics/filters/FEGaussianBlur.cpp » ('j') | Source/platform/graphics/filters/FEGaussianBlur.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/filters/FEGaussianBlur.h

diff --git a/Source/platform/graphics/filters/FEGaussianBlur.h b/Source/platform/graphics/filters/FEGaussianBlur.h

index 05fed149a8b5b52252e6fce2192034e83a3af734..f6b0a13f0dd3f6009e3e1459e1d6ea910aa2b77e 100644

--- a/Source/platform/graphics/filters/FEGaussianBlur.h

+++ b/Source/platform/graphics/filters/FEGaussianBlur.h

@@ -40,8 +40,8 @@ public:

virtual FloatRect mapRect(const FloatRect&, bool forward = true) OVERRIDE FINAL;

virtual FloatRect determineAbsolutePaintRect(const FloatRect& requestedRect) OVERRIDE;

- static void calculateKernelSize(Filter*, unsigned& kernelSizeX, unsigned& kernelSizeY, float stdX, float stdY);

- static void calculateUnscaledKernelSize(unsigned& kernelSizeX, unsigned& kernelSizeY, float stdX, float stdY);

+ static IntSize calculateKernelSize(Filter*, float stdX, float stdY);

Stephen White 2014/03/26 00:22:21 Nit: it seems inconsistent for calculateUnscaledKe

+ static IntSize calculateUnscaledKernelSize(FloatPoint std);

pdr. 2014/03/26 00:00:13 Can these functions take const references instead?

Savago 2014/03/26 00:12:24 Indeed, they can. I will update the patch.

Stephen White 2014/03/26 00:22:21 This should probably be const FloatPoint&.

virtual TextStream& externalRepresentation(TextStream&, int indention) const OVERRIDE;