Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2115103002:
Support for retreiving the monitor color space on X11. (Closed)
DescriptionSupport for retreiving the monitor color space on X11.
BUG=622133
Committed: https://crrev.com/b0df9e3fcbca19d2a625fa274172bd3be4116261
Committed: https://crrev.com/09d613c9521618057602b7fe451da352ad1051b5
Cr-Original-Commit-Position: refs/heads/master@{#403958}
Cr-Commit-Position: refs/heads/master@{#416305}
Patch Set 1 #Patch Set 2 : BUILD.gn fix #Patch Set 3 : merged #Patch Set 4 : merged #
Messages
Total messages: 26 (12 generated)
hubbe@chromium.org changed reviewers: + ccameron@chromium.org
I haven't figured out a way to make this *DO* anything yet, but the function is called and seems to return a valid ICC profile if one has been configured on the X server. (using "dispwin -I SomeICCProfile.icc")
lgtm -- at some point we're going to want to tie all of this into the display::Display frameworks, but for now this will at least send a profile to the renderer for image color correction. Make sure that the query call is pretty fast -- it is made every time we create a new renderer. This may change a bazillion layout tests on Linux. If you want to communicate this over to the GLRenderer, you can send it to the ui::Compositor right after it is created at: https://cs.chromium.org/chromium/src/ui/aura/window_tree_host.cc?rcl=14673875... [that, too, should eventually become multi-monitor aware]
On 2016/07/01 22:01:12, ccameron wrote: > lgtm -- at some point we're going to want to tie all of this into the > display::Display frameworks, but for now this will at least send a profile to > the renderer for image color correction. Make sure that the query call is pretty > fast -- it is made every time we create a new renderer. > > This may change a bazillion layout tests on Linux. > > If you want to communicate this over to the GLRenderer, you can send it to the > ui::Compositor right after it is created at: > https://cs.chromium.org/chromium/src/ui/aura/window_tree_host.cc?rcl=14673875... > > [that, too, should eventually become multi-monitor aware] Tried this out on https://webkit.org/blog-files/color-gamut/, and it seems to work on JPEGs at least.
On 2016/07/01 22:21:05, hubbe wrote: > On 2016/07/01 22:01:12, ccameron wrote: > > lgtm -- at some point we're going to want to tie all of this into the > > display::Display frameworks, but for now this will at least send a profile to > > the renderer for image color correction. Make sure that the query call is > pretty > > fast -- it is made every time we create a new renderer. > > > > This may change a bazillion layout tests on Linux. > > > > If you want to communicate this over to the GLRenderer, you can send it to the > > ui::Compositor right after it is created at: > > > https://cs.chromium.org/chromium/src/ui/aura/window_tree_host.cc?rcl=14673875... > > > > [that, too, should eventually become multi-monitor aware] > > Tried this out on https://webkit.org/blog-files/color-gamut/, and it seems to > work on JPEGs at least. Also, I doubt ANY of our bots set a color profile, so I doubt it will change any tests.
The CQ bit was checked by hubbe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ccameron@chromium.org Link to the patchset: https://codereview.chromium.org/2115103002/#ps20001 (title: "BUILD.gn fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Support for retreiving the monitor color space on X11. BUG=622133 ========== to ========== Support for retreiving the monitor color space on X11. BUG=622133 Committed: https://crrev.com/b0df9e3fcbca19d2a625fa274172bd3be4116261 Cr-Commit-Position: refs/heads/master@{#403958} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b0df9e3fcbca19d2a625fa274172bd3be4116261 Cr-Commit-Position: refs/heads/master@{#403958}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2160133002/ by hubbe@chromium.org. The reason for reverting is: Temporary revert as it breaks layout tests for many people. .
Message was sent while issue was closed.
On 2016/07/18 23:30:40, hubbe wrote: > A revert of this CL (patchset #2 id:20001) has been created in > https://codereview.chromium.org/2160133002/ by mailto:hubbe@chromium.org. > > The reason for reverting is: Temporary revert as it breaks layout tests for many > people. > . This should be able to be re-landed now that https://codereview.chromium.org/2226733003/ has landed.
Message was sent while issue was closed.
On 2016/09/02 16:47:41, ccameron wrote: > On 2016/07/18 23:30:40, hubbe wrote: > > A revert of this CL (patchset #2 id:20001) has been created in > > https://codereview.chromium.org/2160133002/ by mailto:hubbe@chromium.org. > > > > The reason for reverting is: Temporary revert as it breaks layout tests for > many > > people. > > . > > This should be able to be re-landed now that > https://codereview.chromium.org/2226733003/ has landed. <steepled_fingers>eeeexcellent</steepled_fingers<>
Message was sent while issue was closed.
Description was changed from ========== Support for retreiving the monitor color space on X11. BUG=622133 Committed: https://crrev.com/b0df9e3fcbca19d2a625fa274172bd3be4116261 Cr-Commit-Position: refs/heads/master@{#403958} ========== to ========== Support for retreiving the monitor color space on X11. BUG=622133 Committed: https://crrev.com/b0df9e3fcbca19d2a625fa274172bd3be4116261 Cr-Commit-Position: refs/heads/master@{#403958} ==========
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by hubbe@chromium.org
The CQ bit was checked by hubbe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ccameron@chromium.org Link to the patchset: https://codereview.chromium.org/2115103002/#ps60001 (title: "merged")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Support for retreiving the monitor color space on X11. BUG=622133 Committed: https://crrev.com/b0df9e3fcbca19d2a625fa274172bd3be4116261 Cr-Commit-Position: refs/heads/master@{#403958} ========== to ========== Support for retreiving the monitor color space on X11. BUG=622133 Committed: https://crrev.com/b0df9e3fcbca19d2a625fa274172bd3be4116261 Cr-Commit-Position: refs/heads/master@{#403958} ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Support for retreiving the monitor color space on X11. BUG=622133 Committed: https://crrev.com/b0df9e3fcbca19d2a625fa274172bd3be4116261 Cr-Commit-Position: refs/heads/master@{#403958} ========== to ========== Support for retreiving the monitor color space on X11. BUG=622133 Committed: https://crrev.com/b0df9e3fcbca19d2a625fa274172bd3be4116261 Committed: https://crrev.com/09d613c9521618057602b7fe451da352ad1051b5 Cr-Original-Commit-Position: refs/heads/master@{#403958} Cr-Commit-Position: refs/heads/master@{#416305} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/09d613c9521618057602b7fe451da352ad1051b5 Cr-Commit-Position: refs/heads/master@{#416305} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
