Issue 2115007: Annotate load flags and net errors with their symbolic name....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2115007: Annotate load flags and net errors with their symbolic name.... (Closed)

Created:
10 years, 7 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, arv (Not doing code reviews), darin-cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Annotate load flags and net errors with their symbolic name. Here are some examples showing what it looks like now (the stuff in parenthesis is new): --> load_flags = 8240 (DISABLE_CACHE | DISABLE_INTERCEPT | DO_NOT_SAVE_COOKIES) --> net_error = -105 (NAME_NOT_RESOLVED) BUG=37421 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47552

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : address willchan's comment #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -132 lines)			Patch
M	chrome/browser/dom_ui/net_internals_ui.cc	View	1 2	1 chunk	+26 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/net_internals/logviewpainter.js	View	1 2	1 chunk	+44 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/net_internals/main.js	View	1 2	2 chunks	+10 lines, -0 lines	0 comments	Download
M	net/base/load_flags.h	View		1 chunk	+7 lines, -69 lines	0 comments	Download
A +	net/base/load_flags_list.h	View	1 2	1 chunk	+56 lines, -61 lines	0 comments	Download
M	net/net.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

LGTM http://codereview.chromium.org/2115007/diff/6001/7005 File net/base/load_flags_list.h (right): http://codereview.chromium.org/2115007/diff/6001/7005#newcode4 net/base/load_flags_list.h:4: Please add comments explaining what this is. You ...

10 years, 7 months ago (2010-05-18 18:58:56 UTC) #2

eroman

10 years, 7 months ago (2010-05-18 19:32:55 UTC) #3

http://codereview.chromium.org/2115007/diff/6001/7005
File net/base/load_flags_list.h (right):

http://codereview.chromium.org/2115007/diff/6001/7005#newcode4
net/base/load_flags_list.h:4: 
On 2010/05/18 18:58:56, willchan wrote:
> Please add comments explaining what this is.  You need to explain that this is
a
> list of the load flags and their values, and that users are supposed to
provide
> a definition of the LOAD_FLAG macro for their use case.

Done.

Expand Messages | Collapse Messages