Chromium Code Reviews
Help | Chromium Project | Sign in
(190)

Issue 2115007: Annotate load flags and net errors with their symbolic name.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by eroman
Modified:
2 years, 10 months ago
Reviewers:
willchan
CC:
chromium-reviews_chromium.org, cbentzel+watch_chromium.org, arv, darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Annotate load flags and net errors with their symbolic name.

Here are some examples showing what it looks like now (the stuff in parenthesis is new):

--> load_flags = 8240 (DISABLE_CACHE | DISABLE_INTERCEPT | DO_NOT_SAVE_COOKIES)

--> net_error = -105 (NAME_NOT_RESOLVED)

BUG=37421
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47552

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : address willchan's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -132 lines) Lint Patch
M chrome/browser/dom_ui/net_internals_ui.cc View 1 2 1 chunk +26 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/resources/net_internals/logviewpainter.js View 1 2 1 chunk +44 lines, -2 lines 0 comments 0 errors Download
M chrome/browser/resources/net_internals/main.js View 1 2 2 chunks +10 lines, -0 lines 0 comments 0 errors Download
M net/base/load_flags.h View 1 chunk +7 lines, -69 lines 0 comments 1 errors Download
A + net/base/load_flags_list.h View 1 2 1 chunk +56 lines, -61 lines 0 comments 0 errors Download
M net/net.gyp View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 3
eroman
Sorry to keep spamming you with these :)
3 years, 11 months ago #1
willchan
LGTM http://codereview.chromium.org/2115007/diff/6001/7005 File net/base/load_flags_list.h (right): http://codereview.chromium.org/2115007/diff/6001/7005#newcode4 net/base/load_flags_list.h:4: Please add comments explaining what this is. You ...
3 years, 11 months ago #2
eroman
3 years, 11 months ago #3
http://codereview.chromium.org/2115007/diff/6001/7005
File net/base/load_flags_list.h (right):

http://codereview.chromium.org/2115007/diff/6001/7005#newcode4
net/base/load_flags_list.h:4: 
On 2010/05/18 18:58:56, willchan wrote:
> Please add comments explaining what this is.  You need to explain that this is
a
> list of the load flags and their values, and that users are supposed to
provide
> a definition of the LOAD_FLAG macro for their use case.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6