[Chromecast] Fix base_unittests filters for audio-only builds

[Chromecast] Fix base_unittests filters for audio-only builds

Only the last --gtest_filter arg in the command line is used
(any previous instances are ignored), so simply appending the
command line won't work. Just specify the entire correct filter
for now.

BUG=

Committed: https://crrev.com/17fb85f0759feef15ab070c5b27f88d1e24ffe17
Cr-Commit-Position: refs/heads/master@{#403794}

[kmackay, 2016-07-01 18:04:18]

kmackay@chromium.org changed reviewers:
+ almasrymina@chromium.org, halliwell@chromium.org, mbjorge@chromium.org,
wzhong@chromium.org

[almasrymina, 2016-07-01 18:49:37]

On 2016/07/01 18:04:19, kmackay wrote:

lgtm.

[wzhong, 2016-07-01 19:42:00]

Still love the overriding feature.

Can the test filers be combined to single "--gtest_filer" switch and separated
by colon?

[kmackay, 2016-07-01 20:29:45]

On 2016/07/01 19:42:00, wzhong wrote:
> Still love the overriding feature.
> 
> Can the test filers be combined to single "--gtest_filer" switch and separated
> by colon?

Not directly (you need to do some work to build up the switch value properly).
Also, I don't think it's necessarily a good idea to change the behaviour of how
overriding works (ie, concatenating filters rather than ignoring the old value)
since some of our current filter specification might rely on the "ignoring"
behaviour.

I believe mbjorge is thinking of modifying the way that we specify filters to
make it more convenient.

[halliwell, 2016-07-01 22:17:19]

On 2016/07/01 20:29:45, kmackay wrote:
> On 2016/07/01 19:42:00, wzhong wrote:
> > Still love the overriding feature.
> > 
> > Can the test filers be combined to single "--gtest_filer" switch and
separated
> > by colon?
> 
> Not directly (you need to do some work to build up the switch value properly).
> Also, I don't think it's necessarily a good idea to change the behaviour of
how
> overriding works (ie, concatenating filters rather than ignoring the old
value)
> since some of our current filter specification might rely on the "ignoring"
> behaviour.
> 
> I believe mbjorge is thinking of modifying the way that we specify filters to
> make it more convenient.

lgtm

[wzhong, 2016-07-01 23:21:10]

lgtm

[kmackay, 2016-07-01 23:23:04]

The CQ bit was checked by kmackay@chromium.org

[commit-bot: I haz the power, 2016-07-01 23:23:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 23:29:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 23:29:14]

Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[kmackay, 2016-07-05 15:21:03]

The CQ bit was checked by kmackay@chromium.org

[commit-bot: I haz the power, 2016-07-05 15:21:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 15:26:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-05 15:26:13]

Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[kmackay, 2016-07-05 16:37:57]

The CQ bit was checked by kmackay@chromium.org

[commit-bot: I haz the power, 2016-07-05 16:38:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 16:42:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-05 16:44:02]

Description was changed from

==========
[Chromecast] Fix base_unittests filters for audio-only builds

Only the last --gtest_filter arg in the command line is used
(any previous instances are ignored), so simply appending the
command line won't work. Just specify the entire correct filter
for now.

BUG=
==========

to

==========
[Chromecast] Fix base_unittests filters for audio-only builds

Only the last --gtest_filter arg in the command line is used
(any previous instances are ignored), so simply appending the
command line won't work. Just specify the entire correct filter
for now.

BUG=

Committed: https://crrev.com/17fb85f0759feef15ab070c5b27f88d1e24ffe17
Cr-Commit-Position: refs/heads/master@{#403794}
==========

[commit-bot: I haz the power, 2016-07-05 16:44:03]

Patchset 1 (id:??) landed as
https://crrev.com/17fb85f0759feef15ab070c5b27f88d1e24ffe17
Cr-Commit-Position: refs/heads/master@{#403794}