chromecast/tools/build/generate_test_lists.py - Issue 2115003002: [Chromecast] Fix base_unittests filters for audio-only builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/tools/build/generate_test_lists.py

Issue 2115003002: [Chromecast] Fix base_unittests filters for audio-only builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromecast/tools/build/generate_test_lists.py

diff --git a/chromecast/tools/build/generate_test_lists.py b/chromecast/tools/build/generate_test_lists.py

index c343c69daa12a382203ff3c282c1160e402f0c18..120afd65eeac2ac45e49d8af00aca2729f4c0b7b 100755

--- a/chromecast/tools/build/generate_test_lists.py

+++ b/chromecast/tools/build/generate_test_lists.py

@@ -53,10 +53,9 @@ def CombineList(test_files_dir, list_output_file, include_filters,

raise Exception("Filter found for unknown target: " +

test_binary_name)

- if test_binary_name in test_filters:

- test_filters[test_binary_name] += " " + filter

- else:

- test_filters[test_binary_name] = filter

+ # Note: This may overwrite a previous rule. This is okay, since higher

+ # priority files are evaluated after lower priority files.

+ test_filters[test_binary_name] = filter

test_binaries = [

binary + " " + (additional_runtime_options or "")

« no previous file with comments | « chromecast/BUILD.gn ('k') | no next file » | no next file with comments »