Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2114973003:
Roll clang 274142:274369. (Closed)
|
Created:
4 years, 5 months ago by hans Modified:
4 years, 5 months ago Reviewers:
Nico CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, yunlian, hans, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, dmikurube+clang_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll clang 274142:274369.
Ran `tools/clang/scripts/upload_revision.py 274369`.
Picks up a fix for PR28388: Crash on invalid if.
Also pick up a fix for PR28360: clang-cl crash on an overload resolution + template deduction
BUG=
Committed: https://crrev.com/54c8d0a5e228aa1f3727b7268879fb543c3feca3
Cr-Commit-Position: refs/heads/master@{#403836}
Patch Set 1 #Patch Set 2 : try r274369 instead #Messages
Total messages: 19 (8 generated)
Description was changed from ========== Roll clang 274142:274368. Ran `tools/clang/scripts/upload_revision.py 274368`. Picks up a fix for PR28388: Crash on invalid if. BUG= ========== to ========== Roll clang 274142:274369. Ran `tools/clang/scripts/upload_revision.py 274369`. Picks up a fix for PR28388: Crash on invalid if. BUG= ==========
hans@chromium.org changed reviewers: + thakis@chromium.org
I've started new tryjobs at 274369 (an openmp change, so no-op for us), but using the Chromium revision right before https://codereview.chromium.org/2108823004 Mek_ mentioned earlier on IRC that "every compile error today seems to be accompanied by a clang segfault for me", persumably due to the PR that this roll would fix, so it would be cool if this works and we could get it in.
Patch failure. Maybe wait for https://codereview.chromium.org/2118653003/ to land and then try again at head...
I manually kicked off jobs from the web interface, which I think means the bots will use trunk (with vmpstr's fix).
Just started a new one for linux
goma is ready, started tryjobs
Description was changed from ========== Roll clang 274142:274369. Ran `tools/clang/scripts/upload_revision.py 274369`. Picks up a fix for PR28388: Crash on invalid if. BUG= ========== to ========== Roll clang 274142:274369. Ran `tools/clang/scripts/upload_revision.py 274369`. Picks up a fix for PR28388: Crash on invalid if. Also pick up a fix for PR28360: clang-cl crash on an overload resolution + template deduction BUG= ==========
lgtm
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Roll clang 274142:274369. Ran `tools/clang/scripts/upload_revision.py 274369`. Picks up a fix for PR28388: Crash on invalid if. Also pick up a fix for PR28360: clang-cl crash on an overload resolution + template deduction BUG= ========== to ========== Roll clang 274142:274369. Ran `tools/clang/scripts/upload_revision.py 274369`. Picks up a fix for PR28388: Crash on invalid if. Also pick up a fix for PR28360: clang-cl crash on an overload resolution + template deduction BUG= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Roll clang 274142:274369. Ran `tools/clang/scripts/upload_revision.py 274369`. Picks up a fix for PR28388: Crash on invalid if. Also pick up a fix for PR28360: clang-cl crash on an overload resolution + template deduction BUG= ========== to ========== Roll clang 274142:274369. Ran `tools/clang/scripts/upload_revision.py 274369`. Picks up a fix for PR28388: Crash on invalid if. Also pick up a fix for PR28360: clang-cl crash on an overload resolution + template deduction BUG= Committed: https://crrev.com/54c8d0a5e228aa1f3727b7268879fb543c3feca3 Cr-Commit-Position: refs/heads/master@{#403836} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/54c8d0a5e228aa1f3727b7268879fb543c3feca3 Cr-Commit-Position: refs/heads/master@{#403836} |
