clang-plugins: Don't strip non const references in auto raw ptr fixits.

clang-plugins: Don't strip non const references in auto raw ptr fixits.

This patch updates the clang plugin not to strip references to non const
pointers, since the fixit might modify behavior:

int number;
std::vector<int*> vector{&number};
auto& a = vector[0];
a = nullptr; // Modifies the vector.

Without this patch, the suggestions is to replace auto& with auto*
yielding:

int number;
std::vector<int*> vector{&number};
auto* a = vector[0];
a = nullptr; // Does not modify the vector anymore.

With this patch, the suggestion is the following:

int number;
std::vector<int*> vector{&number};
auto*& a = vector[0];
a = nullptr; // Modifies the vector.

R=dcheng
BUG=554600
Committed: https://crrev.com/678f0872c6250ab00efda5f6aba79b923585dc71
Cr-Commit-Position: refs/heads/master@{#403005}

[vmpstr, 2016-06-29 20:44:39]

Description was changed from

==========
clang-plugins: Don't strip non const references in auto raw ptr fixits.

This patch updates the clang plugin not to strip references to non const
pointers, since the fixit might modify behavior:

int number;
std::vector<int*> vector{&number};
auto& a = vector[0];
a = nullptr; // Modifies the vector.

Without this patch, the suggestions is to replace auto& with auto*
yielding:

int number;
std::vector<int*> vector{&number};
auto* a = vector[0];
a = nullptr; // Does not modify the vector anymore.

With this patch, the suggestion is the following:

int number;
std::vector<int*> vector{&number};
auto*& a = vector[0];
a = nullptr; // Modifies the vector.

R=dcheng
==========

to

==========
clang-plugins: Don't strip non const references in auto raw ptr fixits.

This patch updates the clang plugin not to strip references to non const
pointers, since the fixit might modify behavior:

int number;
std::vector<int*> vector{&number};
auto& a = vector[0];
a = nullptr; // Modifies the vector.

Without this patch, the suggestions is to replace auto& with auto*
yielding:

int number;
std::vector<int*> vector{&number};
auto* a = vector[0];
a = nullptr; // Does not modify the vector anymore.

With this patch, the suggestion is the following:

int number;
std::vector<int*> vector{&number};
auto*& a = vector[0];
a = nullptr; // Modifies the vector.

R=dcheng
BUG=554600
==========

[vmpstr, 2016-06-29 20:49:15]

Please take a look. 

I talked to danakj about this and we're OK with a suggestion to replace "auto&"
with "auto*&" in these cases, although it looks a bit weird. 

Does that sound reasonable?

[Nico, 2016-06-29 20:53:58]

Makes sense to me.

[dcheng, 2016-06-29 22:27:01]

lgtm

[vmpstr, 2016-06-29 22:27:35]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-06-29 22:30:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 00:07:13]

Description was changed from

==========
clang-plugins: Don't strip non const references in auto raw ptr fixits.

This patch updates the clang plugin not to strip references to non const
pointers, since the fixit might modify behavior:

int number;
std::vector<int*> vector{&number};
auto& a = vector[0];
a = nullptr; // Modifies the vector.

Without this patch, the suggestions is to replace auto& with auto*
yielding:

int number;
std::vector<int*> vector{&number};
auto* a = vector[0];
a = nullptr; // Does not modify the vector anymore.

With this patch, the suggestion is the following:

int number;
std::vector<int*> vector{&number};
auto*& a = vector[0];
a = nullptr; // Modifies the vector.

R=dcheng
BUG=554600
==========

to

==========
clang-plugins: Don't strip non const references in auto raw ptr fixits.

This patch updates the clang plugin not to strip references to non const
pointers, since the fixit might modify behavior:

int number;
std::vector<int*> vector{&number};
auto& a = vector[0];
a = nullptr; // Modifies the vector.

Without this patch, the suggestions is to replace auto& with auto*
yielding:

int number;
std::vector<int*> vector{&number};
auto* a = vector[0];
a = nullptr; // Does not modify the vector anymore.

With this patch, the suggestion is the following:

int number;
std::vector<int*> vector{&number};
auto*& a = vector[0];
a = nullptr; // Modifies the vector.

R=dcheng
BUG=554600
==========

[commit-bot: I haz the power, 2016-06-30 00:07:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-30 00:10:15]

Description was changed from

==========
clang-plugins: Don't strip non const references in auto raw ptr fixits.

This patch updates the clang plugin not to strip references to non const
pointers, since the fixit might modify behavior:

int number;
std::vector<int*> vector{&number};
auto& a = vector[0];
a = nullptr; // Modifies the vector.

Without this patch, the suggestions is to replace auto& with auto*
yielding:

int number;
std::vector<int*> vector{&number};
auto* a = vector[0];
a = nullptr; // Does not modify the vector anymore.

With this patch, the suggestion is the following:

int number;
std::vector<int*> vector{&number};
auto*& a = vector[0];
a = nullptr; // Modifies the vector.

R=dcheng
BUG=554600
==========

to

==========
clang-plugins: Don't strip non const references in auto raw ptr fixits.

This patch updates the clang plugin not to strip references to non const
pointers, since the fixit might modify behavior:

int number;
std::vector<int*> vector{&number};
auto& a = vector[0];
a = nullptr; // Modifies the vector.

Without this patch, the suggestions is to replace auto& with auto*
yielding:

int number;
std::vector<int*> vector{&number};
auto* a = vector[0];
a = nullptr; // Does not modify the vector anymore.

With this patch, the suggestion is the following:

int number;
std::vector<int*> vector{&number};
auto*& a = vector[0];
a = nullptr; // Modifies the vector.

R=dcheng
BUG=554600

Committed: https://crrev.com/678f0872c6250ab00efda5f6aba79b923585dc71
Cr-Commit-Position: refs/heads/master@{#403005}
==========

[commit-bot: I haz the power, 2016-06-30 00:10:16]

Patchset 1 (id:??) landed as
https://crrev.com/678f0872c6250ab00efda5f6aba79b923585dc71
Cr-Commit-Position: refs/heads/master@{#403005}

[Nico, 2016-07-01 20:00:25]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-07-01 20:00:26]

https://codereview.chromium.org/2108823004/diff/1/tools/clang/plugins/tests/a...
File tools/clang/plugins/tests/auto_raw_pointer.cpp (right):

https://codereview.chromium.org/2108823004/diff/1/tools/clang/plugins/tests/a...
tools/clang/plugins/tests/auto_raw_pointer.cpp:5: #include <utility>
This new test fails on the mac upload bots:
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_upload_clang...
(see bottom)

The plugin tests are supposed to be standalone, please don't include system
headers here (some other tests stub out just the bits they need, see there for
reference).

This is currently blocking clang rolls; please take a look.

[vmpstr, 2016-07-01 20:32:09]

On 2016/07/01 20:00:26, Nico wrote:
>
https://codereview.chromium.org/2108823004/diff/1/tools/clang/plugins/tests/a...
> File tools/clang/plugins/tests/auto_raw_pointer.cpp (right):
> 
>
https://codereview.chromium.org/2108823004/diff/1/tools/clang/plugins/tests/a...
> tools/clang/plugins/tests/auto_raw_pointer.cpp:5: #include <utility>
> This new test fails on the mac upload bots:
>
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_upload_clang...
> (see bottom)
> 
> The plugin tests are supposed to be standalone, please don't include system
> headers here (some other tests stub out just the bits they need, see there for
> reference).
> 
> This is currently blocking clang rolls; please take a look.

Sorry, I didn't realize. I will have a fix ASAP