DevTools: Show user code location for wrapped console.log() calls.

DevTools: Show user code location for wrapped console.log() calls.

Instead of pointing to actual console.log() call done from a framework wrapper function,
we should point to the user code.

BUG=231007
R=pfeldman

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170057

[aandrey, 2014-03-26 08:48:31]

https://codereview.chromium.org/211493002/diff/1/Source/devtools/front_end/Co...
File Source/devtools/front_end/ConsoleViewMessage.js (right):

https://codereview.chromium.org/211493002/diff/1/Source/devtools/front_end/Co...
Source/devtools/front_end/ConsoleViewMessage.js:261: // FIXME: Cache the created
RegExp object.
this will be addressed after https://codereview.chromium.org/212223003/

[pfeldman, 2014-03-26 08:57:25]

lgtm.

note that we might want same for formatting traces in timeline as well.

https://codereview.chromium.org/211493002/diff/1/Source/devtools/front_end/Co...
File Source/devtools/front_end/ConsoleViewMessage.js (right):

https://codereview.chromium.org/211493002/diff/1/Source/devtools/front_end/Co...
Source/devtools/front_end/ConsoleViewMessage.js:258: if
(WebInspector.experimentsSettings.frameworksDebuggingSupport.isEnabled() &&
WebInspector.settings.skipStackFramesSwitch.get()) {
I'd use early return instead.

https://codereview.chromium.org/211493002/diff/1/Source/devtools/front_end/Co...
Source/devtools/front_end/ConsoleViewMessage.js:265: if (regex) {
ditto

[aandrey, 2014-03-26 09:30:18]

https://codereview.chromium.org/211493002/diff/1/Source/devtools/front_end/Co...
File Source/devtools/front_end/ConsoleViewMessage.js (right):

https://codereview.chromium.org/211493002/diff/1/Source/devtools/front_end/Co...
Source/devtools/front_end/ConsoleViewMessage.js:258: if
(WebInspector.experimentsSettings.frameworksDebuggingSupport.isEnabled() &&
WebInspector.settings.skipStackFramesSwitch.get()) {
On 2014/03/26 08:57:25, pfeldman wrote:
> I'd use early return instead.

Done.

https://codereview.chromium.org/211493002/diff/1/Source/devtools/front_end/Co...
Source/devtools/front_end/ConsoleViewMessage.js:265: if (regex) {
On 2014/03/26 08:57:25, pfeldman wrote:
> ditto

Done.

[aandrey, 2014-03-26 09:30:37]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-03-26 09:30:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aandrey@chromium.org/211493002/70001

[commit-bot: I haz the power, 2014-03-26 09:39:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-26 09:39:36]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[aandrey, 2014-03-26 13:01:23]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-03-26 13:01:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aandrey@chromium.org/211493002/70001

[commit-bot: I haz the power, 2014-03-26 13:36:18]

Change committed as 170057