Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2114903002: [Editing][CodeHealth] Allow assert_selection have no anchor sample text. (Closed)

Created:
4 years, 5 months ago by yoichio
Modified:
4 years, 5 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Editing][CodeHealth] Allow assert_selection have no anchor sample text. This enable us to test creating new selection. TEST=LayoutTests/editing/assert_selection.html Committed: https://crrev.com/b392dd0728db0342070faa731c3756e4c9f7fc19 Cr-Commit-Position: refs/heads/master@{#403433}

Patch Set 1 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/editing/assert_selection.html View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/assert_selection.js View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
yoichio
4 years, 5 months ago (2016-07-01 08:48:55 UTC) #4
yosin_UTC9
lgtm
4 years, 5 months ago (2016-07-01 08:54:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114903002/20001
4 years, 5 months ago (2016-07-01 08:54:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 5 months ago (2016-07-01 10:08:15 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 10:10:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b392dd0728db0342070faa731c3756e4c9f7fc19
Cr-Commit-Position: refs/heads/master@{#403433}

Powered by Google App Engine
This is Rietveld 408576698