third_party/WebKit/LayoutTests/editing/assert_selection.js - Issue 2114903002: [Editing][CodeHealth] Allow assert_selection have no anchor sample text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/editing/assert_selection.js

Issue 2114903002: [Editing][CodeHealth] Allow assert_selection have no anchor sample text. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/editing/assert_selection.js

diff --git a/third_party/WebKit/LayoutTests/editing/assert_selection.js b/third_party/WebKit/LayoutTests/editing/assert_selection.js

index c615527057615aa8bb120fe1d2f4e71d7a901b91..6c506eac9586130ff48ded4b0c0c6d526efedf32 100644

--- a/third_party/WebKit/LayoutTests/editing/assert_selection.js

+++ b/third_party/WebKit/LayoutTests/editing/assert_selection.js

@@ -462,8 +462,6 @@ class Serializer {

* @param {!HTMLDocument} document

serialize(document) {

- if (this.selection_.isNone)

- return document.body.firstChild.outerHTML;

this.serializeChildren(document.body);

return this.strings_.join('');

}

@@ -534,7 +532,7 @@ class Sample {

load(sampleText) {

const anchorMarker = sampleText.indexOf('^');

const focusMarker = sampleText.indexOf('|');

- if (focusMarker < 0) {

+ if (focusMarker < 0 && anchorMarker >= 0) {

throw new Error(`You should specify caret position in "${sampleText}".`);

}

if (focusMarker != sampleText.lastIndexOf('|')) {

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/assert_selection.html ('k') | no next file » | no next file with comments »