Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2114823003: [sql] Disable shortcuts recovery code. (Closed)

Created:
4 years, 5 months ago by Scott Hess - ex-Googler
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@zzsql_recover_shortcuts_review
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Disable shortcuts recovery code. Prevent the shortcuts recovery code from actually running, but leave it all in place. This is intended for emergency use if someone sees problems with: https://codereview.chromium.org/1832173002/ BUG=597785

Patch Set 1 #

Patch Set 2 : Oh, and disable the unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/omnibox/browser/shortcuts_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/browser/shortcuts_database_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1832173002 Patch 240001

Messages

Total messages: 6 (3 generated)
Scott Hess - ex-Googler
Oh, and disable the unit test.
4 years, 5 months ago (2016-07-02 04:27:32 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114823003/20001
4 years, 5 months ago (2016-07-02 04:27:49 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-02 05:01:34 UTC) #5 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698