Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2114783003: Fix the testharness async test API usage (Closed)

Created:
4 years, 5 months ago by kochi
Modified:
4 years, 5 months ago
Reviewers:
hayato
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the testharness async test API usage This fixes the usage of testharness.js async_test API usages in pointer lock test for Shadow DOM. BUG=622584 Committed: https://crrev.com/7108fffd85ed6c21acdb88991b48395ae2cbb822 Cr-Commit-Position: refs/heads/master@{#403626}

Patch Set 1 #

Patch Set 2 : More fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -42 lines) Patch
M third_party/WebKit/LayoutTests/shadow-dom/pointer-lock-in-shadow.html View 1 3 chunks +11 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/v0/pointer-lock-in-shadow.html View 1 2 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/v0/pointer-lock-in-shadow2.html View 1 2 chunks +9 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/v0/pointer-lock-in-shadow3.html View 1 2 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114783003/20001
4 years, 5 months ago (2016-07-01 09:23:20 UTC) #2
kochi
PTAL It looks the old test worked, but this should be proper API usage for ...
4 years, 5 months ago (2016-07-01 09:35:37 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-01 10:41:54 UTC) #6
hayato
lgtm
4 years, 5 months ago (2016-07-01 13:07:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114783003/20001
4 years, 5 months ago (2016-07-03 15:56:48 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-04 01:16:34 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 01:17:58 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7108fffd85ed6c21acdb88991b48395ae2cbb822
Cr-Commit-Position: refs/heads/master@{#403626}

Powered by Google App Engine
This is Rietveld 408576698