Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: third_party/WebKit/LayoutTests/shadow-dom/v0/pointer-lock-in-shadow3.html

Issue 2114783003: Fix the testharness async test API usage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More fixes Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/shadow-dom/v0/pointer-lock-in-shadow2.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/shadow-dom/v0/pointer-lock-in-shadow3.html
diff --git a/third_party/WebKit/LayoutTests/shadow-dom/v0/pointer-lock-in-shadow3.html b/third_party/WebKit/LayoutTests/shadow-dom/v0/pointer-lock-in-shadow3.html
index 9849b3d246d87406d44c61f2f7ec37f675ee9aca..105000468fcc8c9cfa05fbe0cda1da226ee24e22 100644
--- a/third_party/WebKit/LayoutTests/shadow-dom/v0/pointer-lock-in-shadow3.html
+++ b/third_party/WebKit/LayoutTests/shadow-dom/v0/pointer-lock-in-shadow3.html
@@ -24,12 +24,9 @@
<script>
async_test((test) => {
- document.onpointerlockerror = () => {
- assert_true(false, 'onpointerlockerror is not expected.');
- test.done();
- };
+ document.onpointerlockerror = test.unreached_func('onpointerlockerror is not expected.');
- document.onpointerlockchange = () => {
+ document.onpointerlockchange = test.step_func(() => {
// Not interested in handling before or after exitPointerLock.
if (document.pointerLockElement === null)
return;
@@ -42,17 +39,19 @@ async_test((test) => {
document.exitPointerLock();
test.done();
- };
+ });
convertTemplatesToShadowRootsWithin(host);
var hostV1inV1 = hostV1.shadowRoot.querySelector('#hostV1inV1');
var hostV0inV1inV1 = hostV1inV1.shadowRoot.querySelector('#hostV0inV1inV1');
- assert_equals(document.pointerLockElement, null);
- assert_equals(host.shadowRoot.pointerLockElement, null);
- assert_equals(hostV1.shadowRoot.pointerLockElement, null);
- assert_equals(hostV1inV1.shadowRoot.pointerLockElement, null);
- assert_equals(hostV0inV1inV1.shadowRoot.pointerLockElement, null);
+ test.step(() => {
+ assert_equals(document.pointerLockElement, null);
+ assert_equals(host.shadowRoot.pointerLockElement, null);
+ assert_equals(hostV1.shadowRoot.pointerLockElement, null);
+ assert_equals(hostV1inV1.shadowRoot.pointerLockElement, null);
+ assert_equals(hostV0inV1inV1.shadowRoot.pointerLockElement, null);
+ });
var canvas = hostV0inV1inV1.shadowRoot.querySelector('canvas');
canvas.requestPointerLock();
« no previous file with comments | « third_party/WebKit/LayoutTests/shadow-dom/v0/pointer-lock-in-shadow2.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698