Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2114763002: Do not cancel precache periodic GCM task if current network is non-WiFi (Closed)

Created:
4 years, 5 months ago by tbansal1
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, wifiprefetch-reviews_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Do not cancel precache periodic GCM task if current network is non-WiFi Only the network prediction enabled preference should be used to schedule or cancel periodic GCM task. The GCM task itself will run only when suitable for precaching. BUG=616956 Review-Url: https://codereview.chromium.org/2037913002 Cr-Commit-Position: refs/heads/master@{#398119} (cherry picked from commit 2fd4cfeadfcdb8b2c29d4d747fe8106200b8855b) Committed: https://chromium.googlesource.com/chromium/src/+/102c583b8750c57f91285db22de30ccf5aaa842f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tbansal1
4 years, 5 months ago (2016-06-30 20:23:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
102c583b8750c57f91285db22de30ccf5aaa842f.

Powered by Google App Engine
This is Rietveld 408576698