Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2037913002: Do not cancel precache periodic GCM task if current network is non-WiFi (Closed)

Created:
4 years, 6 months ago by Raj
Modified:
4 years, 6 months ago
Reviewers:
bengr
CC:
chromium-reviews, wifiprefetch-reviews_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not cancel precache periodic GCM task if current network is non-WiFi Only the network prediction enabled preference should be used to schedule or cancel periodic GCM task. The GCM task itself will run only when suitable for precaching. BUG=616956 Committed: https://crrev.com/2fd4cfeadfcdb8b2c29d4d747fe8106200b8855b Cr-Commit-Position: refs/heads/master@{#398119}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Raj
4 years, 6 months ago (2016-06-03 00:15:41 UTC) #2
bengr
lgtm
4 years, 6 months ago (2016-06-06 19:03:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037913002/1
4 years, 6 months ago (2016-06-06 19:39:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 20:54:52 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 20:56:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fd4cfeadfcdb8b2c29d4d747fe8106200b8855b
Cr-Commit-Position: refs/heads/master@{#398119}

Powered by Google App Engine
This is Rietveld 408576698