Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2114663004: [MD settings] cast elements to cr_dialog (Closed)

Created:
4 years, 5 months ago by dschuyler
Modified:
4 years, 5 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, vitalyp+closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] cast elements to cr_dialog This CL adds type checking for dialog elements found by this.$.dialog. There is no functional change aside from the type checking. BUG=393873 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/016c0bd1748c39a60bc4561269c5ac9c52811f4e Cr-Commit-Position: refs/heads/master@{#403347}

Patch Set 1 #

Messages

Total messages: 13 (7 generated)
dschuyler
Hi, Here's the dialog type casting that ya asked about. I still think it's rather ...
4 years, 5 months ago (2016-06-30 22:56:17 UTC) #4
dpapad
LGTM with nit. crbug.com/425627 is the most generic bug we could use for this CL. ...
4 years, 5 months ago (2016-06-30 22:58:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114663004/1
4 years, 5 months ago (2016-06-30 23:39:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 23:47:04 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 23:47:13 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 23:50:11 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/016c0bd1748c39a60bc4561269c5ac9c52811f4e
Cr-Commit-Position: refs/heads/master@{#403347}

Powered by Google App Engine
This is Rietveld 408576698