chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.js - Issue 2114663004: [MD settings] cast elements to cr_dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.js

Issue 2114663004: [MD settings] cast elements to cr_dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js ('k') | chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.js

diff --git a/chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.js b/chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.js

index b2910a3f0ddb5bccf12fcc926712fd0048b9561d..df78b53004694536a1a8d5ccdfd43d86df7cd17f 100644

--- a/chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.js

+++ b/chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.js

@@ -27,7 +27,7 @@ Polymer({

/** @override */

attached: function() {

- this.$.dialog.open();

+ /** @type {!CrDialogElement} */ (this.$.dialog).open();

/**

@@ -77,18 +77,18 @@ Polymer({

/** @private */

onCancelTap_: function() {

- this.$.dialog.close();

+ /** @type {!CrDialogElement} */ (this.$.dialog).close();

/** @private */

onOkTap_: function() {

this.browserProxy_.deleteCertificate(this.model.id).then(

function() {

- this.$.dialog.close();

+ /** @type {!CrDialogElement} */ (this.$.dialog).close();

}.bind(this),

/** @param {!CertificatesError} error */

function(error) {

- this.$.dialog.close();

+ /** @type {!CrDialogElement} */ (this.$.dialog).close();

this.fire('certificates-error', error);

}.bind(this));