Windows: Make it possible to print text with GDI.

Windows: Make it possible to print text with GDI.

This only affects the printing of web pages directly on the host.

- Renderer tells the browser if the print job is HTML. (AKA modifiable)
-- Browser does lots of plumbing to get the bool into PrintSettings.
-- Print preview already sends this info and it just needs extraction.
- Add --disable-gdi-text-printing for reverting to old behavior.
- Browser plumbs bool to PdfToEmfConverter to the utility process.
- Utility plumbs bool into the PDF plugin code into PDFium.
- Move unused PreCacheFontCharacters code out of RenderThreadImpl.
-- Use it in PrintingHandler instead.
- Remove dead code, fix lint errors / typos.

BUG=409472
Committed: https://crrev.com/e85e6b6cf8d2a9bb95796cbe87efac18fc9689ff
Cr-Commit-Position: refs/heads/master@{#414209}

[Lei Zhang, 2016-06-30 08:04:53]

Description was changed from

==========
Windows: Make it possible to print text with GDI.

Feature can be enabled with --enable-gdi-text-printing, and it only
affects the printing of web pages.

BUG=409472
==========

to

==========
Windows: Make it possible to print text with GDI.

Feature can be enabled with --enable-gdi-text-printing, and it only
affects the printing of web pages.

- Renderer tells the browser if the print job is HTML. (AKA modifiable)
-- Browser does lots of plumbing to get the bool into PrintSettings.
-- Print preview already sends this info and it just needs extraction.
- Add command line flag, gate feature on the flag.
- Browser plumbs bool to PdfToEmfConverter to the utility process.
- Utility plumbs bool into the PDF plugin code into PDFium.
- Move unused PreCacheFontCharacters code out of RenderThreadImpl.
-- Use it in PrintingHandler instead.
- Remove dead code, fix lint errors / typos.

BUG=409472
==========

[Lei Zhang, 2016-06-30 08:04:54]

thestig@chromium.org changed reviewers:
+ creis@chromium.org, ochang@chromium.org, scottmg@chromium.org,
vitalybuka@chromium.org

[Lei Zhang, 2016-06-30 08:09:22]

This requires https://codereview.chromium.org/2113563003/ and a DEPS roll to
work. Assumes the PDFium CL lands as is.

scottmg / vitalybuka: Please look things over.

ochang: Security review for IPC messages. One unused message is being moved to
where it will get used, and one extra bit of info is being sent when printing
with the system print dialog. (ctrl + shift + p) - the same bit is already sent
over a different message for print preview.

creis: content/OWNERS for unused code removal. Most of the code is being moved
into chrome and put to use. Also, in case you are wondering what I've been up
to.

[scottmg, 2016-06-30 17:48:31]

So much plumbing for a bool!

I'd probably just remove the command line flag and wait a day to land it, but up
to you.

https://codereview.chromium.org/2114583002/diff/1/chrome/browser/printing/pri...
File chrome/browser/printing/print_job_worker.h (right):

https://codereview.chromium.org/2114583002/diff/1/chrome/browser/printing/pri...
chrome/browser/printing/print_job_worker.h:53: bool is_modifiable);
This is probably just my lack of knowledge of this area, but I don't know what
is_modifiable means here. Maybe you could add a comment here, and/or the other
.h, and/or where the ipc struct is filled out.

https://codereview.chromium.org/2114583002/diff/1/chrome/browser/printing/pri...
File chrome/browser/printing/printing_message_filter.cc (left):

https://codereview.chromium.org/2114583002/diff/1/chrome/browser/printing/pri...
chrome/browser/printing/printing_message_filter.cc:29: #if defined(OS_CHROMEOS)
heh, I was checking to to see why we didn't need this on cros any more, but
nope, all decoy.)

https://codereview.chromium.org/2114583002/diff/1/printing/printing_context_w...
File printing/printing_context_win.cc (left):

https://codereview.chromium.org/2114583002/diff/1/printing/printing_context_w...
printing/printing_context_win.cc:29: void AssingResult(PrintingContext::Result*
out, PrintingContext::Result in) {
(probably meant to be "assign"? not sure)

https://codereview.chromium.org/2114583002/diff/1/printing/printing_context_w...
File printing/printing_context_win.cc (right):

https://codereview.chromium.org/2114583002/diff/1/printing/printing_context_w...
printing/printing_context_win.cc:216: scoped_dev_mode =
CreateDevMode(printer.Get(), scoped_dev_mode.get());
I don't understand this change, why do we need to always do this now?

[Charlie Reis, 2016-06-30 18:38:41]

Thanks.  I'm mostly deferring to the other reviewers, but removals from content/
LGTM.

https://codereview.chromium.org/2114583002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_message_filter.cc (left):

https://codereview.chromium.org/2114583002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_message_filter.cc:356: //
FontCacheDispatcher too. http://crbug.com/356346.
Can http://crbug.com/356346 be marked fixed after this?

[Oliver Chang, 2016-06-30 19:13:13]

ipc lgtm

[Lei Zhang, 2016-06-30 22:29:35]

Yes, so much plumbing, but that's the crazy world we live in.

https://codereview.chromium.org/2114583002/diff/1/chrome/browser/printing/pri...
File chrome/browser/printing/print_job_worker.h (right):

https://codereview.chromium.org/2114583002/diff/1/chrome/browser/printing/pri...
chrome/browser/printing/print_job_worker.h:53: bool is_modifiable);
On 2016/06/30 17:48:30, scottmg wrote:
> This is probably just my lack of knowledge of this area, but I don't know what
> is_modifiable means here. Maybe you could add a comment here, and/or the other
> .h, and/or where the ipc struct is filled out.

I added a comment here. There's several "is_modifiable" members in
components/printing/common/print_messages.h, and some of them are documented, so
there's probably enough documentation there. They all mean the same thing.

https://codereview.chromium.org/2114583002/diff/1/chrome/browser/printing/pri...
File chrome/browser/printing/printing_message_filter.cc (left):

https://codereview.chromium.org/2114583002/diff/1/chrome/browser/printing/pri...
chrome/browser/printing/printing_message_filter.cc:29: #if defined(OS_CHROMEOS)
On 2016/06/30 17:48:31, scottmg wrote:
> heh, I was checking to to see why we didn't need this on cros any more, but
> nope, all decoy.)

There was CrOS only code in this file, but it probably got refactored away.

https://codereview.chromium.org/2114583002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_message_filter.cc (left):

https://codereview.chromium.org/2114583002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_message_filter.cc:356: //
FontCacheDispatcher too. http://crbug.com/356346.
On 2016/06/30 18:38:41, Charlie Reis wrote:
> Can http://crbug.com/356346 be marked fixed after this?

scottmg: ^

https://codereview.chromium.org/2114583002/diff/1/printing/printing_context_w...
File printing/printing_context_win.cc (left):

https://codereview.chromium.org/2114583002/diff/1/printing/printing_context_w...
printing/printing_context_win.cc:29: void AssingResult(PrintingContext::Result*
out, PrintingContext::Result in) {
On 2016/06/30 17:48:31, scottmg wrote:
> (probably meant to be "assign"? not sure)

Oh, ya, that would make more sense. :)

https://codereview.chromium.org/2114583002/diff/1/printing/printing_context_w...
File printing/printing_context_win.cc (right):

https://codereview.chromium.org/2114583002/diff/1/printing/printing_context_w...
printing/printing_context_win.cc:216: scoped_dev_mode =
CreateDevMode(printer.Get(), scoped_dev_mode.get());
On 2016/06/30 17:48:31, scottmg wrote:
> I don't understand this change, why do we need to always do this now?

It's an else after return. e.g.

if (foo)
  return bar;
else
  qux;

is the same as:

if (foo)
  return bar;
qux;

[scottmg, 2016-06-30 22:31:53]

lgtm

https://codereview.chromium.org/2114583002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_message_filter.cc (left):

https://codereview.chromium.org/2114583002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_message_filter.cc:356: //
FontCacheDispatcher too. http://crbug.com/356346.
On 2016/06/30 22:29:34, Lei Zhang wrote:
> On 2016/06/30 18:38:41, Charlie Reis wrote:
> > Can http://crbug.com/356346 be marked fixed after this?
> 
> scottmg: ^

Who filed that useless bug? Yeah, I'd say so.

https://codereview.chromium.org/2114583002/diff/1/printing/printing_context_w...
File printing/printing_context_win.cc (right):

https://codereview.chromium.org/2114583002/diff/1/printing/printing_context_w...
printing/printing_context_win.cc:216: scoped_dev_mode =
CreateDevMode(printer.Get(), scoped_dev_mode.get());
On 2016/06/30 22:29:35, Lei Zhang wrote:
> On 2016/06/30 17:48:31, scottmg wrote:
> > I don't understand this change, why do we need to always do this now?
> 
> It's an else after return. e.g.
> 
> if (foo)
>   return bar;
> else
>   qux;
> 
> is the same as:
> 
> if (foo)
>   return bar;
> qux;

Doh sorry, missed the return.

[Lei Zhang, 2016-06-30 22:33:27]

On 2016/06/30 17:48:31, scottmg wrote:
> I'd probably just remove the command line flag and wait a day to land it, but
up
> to you.

Ya, at the rate this is going, I may just do that. Unlease the code on M54
Canary and see what happens.

[Lei Zhang, 2016-06-30 22:37:58]

On 2016/06/30 22:33:27, Lei Zhang wrote:
> Ya, at the rate this is going, I may just do that. Unlease the code on M54
> Canary and see what happens.

*unleash* even.

[Lei Zhang, 2016-08-16 02:17:47]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 02:18:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 02:56:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 02:56:47]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Lei Zhang, 2016-08-19 01:30:57]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 01:32:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 03:13:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 03:13:14]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-08-24 16:22:06]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 16:22:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-08-24 16:28:16]

Description was changed from

==========
Windows: Make it possible to print text with GDI.

Feature can be enabled with --enable-gdi-text-printing, and it only
affects the printing of web pages.

- Renderer tells the browser if the print job is HTML. (AKA modifiable)
-- Browser does lots of plumbing to get the bool into PrintSettings.
-- Print preview already sends this info and it just needs extraction.
- Add command line flag, gate feature on the flag.
- Browser plumbs bool to PdfToEmfConverter to the utility process.
- Utility plumbs bool into the PDF plugin code into PDFium.
- Move unused PreCacheFontCharacters code out of RenderThreadImpl.
-- Use it in PrintingHandler instead.
- Remove dead code, fix lint errors / typos.

BUG=409472
==========

to

==========
Windows: Make it possible to print text with GDI.

This only affects the printing of web pages directly on the host.

- Renderer tells the browser if the print job is HTML. (AKA modifiable)
-- Browser does lots of plumbing to get the bool into PrintSettings.
-- Print preview already sends this info and it just needs extraction.
- Add --disable-gdi-text-printing for reverting to old behavior.
- Browser plumbs bool to PdfToEmfConverter to the utility process.
- Utility plumbs bool into the PDF plugin code into PDFium.
- Move unused PreCacheFontCharacters code out of RenderThreadImpl.
-- Use it in PrintingHandler instead.
- Remove dead code, fix lint errors / typos.

BUG=409472
==========

[Lei Zhang, 2016-08-24 16:30:35]

I still have a weird issue with the XPS Document Printer on my workstation, but
not my laptop. Otherwise everything in my small test suite of documents print ok
with several printers. Going to land this today and see how it works in the
wild.

[commit-bot: I haz the power, 2016-08-24 18:50:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 18:50:38]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Lei Zhang, 2016-08-24 19:02:31]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-08-24 19:02:31]

The patchset sent to the CQ was uploaded after l-g-t-m from ochang@chromium.org,
creis@chromium.org, scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2114583002/#ps80001
(title: "rebase again, resolve conflicts")

[commit-bot: I haz the power, 2016-08-24 19:04:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 22:13:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 22:13:33]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Lei Zhang, 2016-08-24 22:18:25]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-08-24 22:19:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 00:00:22]

Description was changed from

==========
Windows: Make it possible to print text with GDI.

This only affects the printing of web pages directly on the host.

- Renderer tells the browser if the print job is HTML. (AKA modifiable)
-- Browser does lots of plumbing to get the bool into PrintSettings.
-- Print preview already sends this info and it just needs extraction.
- Add --disable-gdi-text-printing for reverting to old behavior.
- Browser plumbs bool to PdfToEmfConverter to the utility process.
- Utility plumbs bool into the PDF plugin code into PDFium.
- Move unused PreCacheFontCharacters code out of RenderThreadImpl.
-- Use it in PrintingHandler instead.
- Remove dead code, fix lint errors / typos.

BUG=409472
==========

to

==========
Windows: Make it possible to print text with GDI.

This only affects the printing of web pages directly on the host.

- Renderer tells the browser if the print job is HTML. (AKA modifiable)
-- Browser does lots of plumbing to get the bool into PrintSettings.
-- Print preview already sends this info and it just needs extraction.
- Add --disable-gdi-text-printing for reverting to old behavior.
- Browser plumbs bool to PdfToEmfConverter to the utility process.
- Utility plumbs bool into the PDF plugin code into PDFium.
- Move unused PreCacheFontCharacters code out of RenderThreadImpl.
-- Use it in PrintingHandler instead.
- Remove dead code, fix lint errors / typos.

BUG=409472
==========

[commit-bot: I haz the power, 2016-08-25 00:00:23]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-25 00:02:25]

Description was changed from

==========
Windows: Make it possible to print text with GDI.

This only affects the printing of web pages directly on the host.

- Renderer tells the browser if the print job is HTML. (AKA modifiable)
-- Browser does lots of plumbing to get the bool into PrintSettings.
-- Print preview already sends this info and it just needs extraction.
- Add --disable-gdi-text-printing for reverting to old behavior.
- Browser plumbs bool to PdfToEmfConverter to the utility process.
- Utility plumbs bool into the PDF plugin code into PDFium.
- Move unused PreCacheFontCharacters code out of RenderThreadImpl.
-- Use it in PrintingHandler instead.
- Remove dead code, fix lint errors / typos.

BUG=409472
==========

to

==========
Windows: Make it possible to print text with GDI.

This only affects the printing of web pages directly on the host.

- Renderer tells the browser if the print job is HTML. (AKA modifiable)
-- Browser does lots of plumbing to get the bool into PrintSettings.
-- Print preview already sends this info and it just needs extraction.
- Add --disable-gdi-text-printing for reverting to old behavior.
- Browser plumbs bool to PdfToEmfConverter to the utility process.
- Utility plumbs bool into the PDF plugin code into PDFium.
- Move unused PreCacheFontCharacters code out of RenderThreadImpl.
-- Use it in PrintingHandler instead.
- Remove dead code, fix lint errors / typos.

BUG=409472

Committed: https://crrev.com/e85e6b6cf8d2a9bb95796cbe87efac18fc9689ff
Cr-Commit-Position: refs/heads/master@{#414209}
==========

[commit-bot: I haz the power, 2016-08-25 00:02:26]

Patchset 5 (id:??) landed as
https://crrev.com/e85e6b6cf8d2a9bb95796cbe87efac18fc9689ff
Cr-Commit-Position: refs/heads/master@{#414209}