Windows: Make it possible to print text with GDI.

chrome/browser/printing/print_job_worker.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PRINTING_PRINT_JOB_WORKER_H_
 #define CHROME_BROWSER_PRINTING_PRINT_JOB_WORKER_H_
 
 #include <memory>
 
 #include "base/macros.h"
@@ skipping 27 matching lines @@
   PrintJobWorker(int render_process_id,
                  int render_view_id,
                  PrintJobWorkerOwner* owner);
   virtual ~PrintJobWorker();
 
   void SetNewOwner(PrintJobWorkerOwner* new_owner);
 
   // Initializes the print settings. If |ask_user_for_settings| is true, a
   // Print... dialog box will be shown to ask the user his preference.
   // |is_scripted| should be true for calls coming straight from window.print().
-  void GetSettings(
-      bool ask_user_for_settings,
-      int document_page_count,
-      bool has_selection,
-      MarginType margin_type,
-      bool is_scripted);
+  void GetSettings(bool ask_user_for_settings,
+                   int document_page_count,
+                   bool has_selection,
+                   MarginType margin_type,
+                   bool is_scripted,
+                   bool is_modifiable);

[scottmg, 2016/06/30 17:48:30]

This is probably just my lack of knowledge of this area, but I don't know what
is_modifiable means here. Maybe you could add a comment here, and/or the other
.h, and/or where the ipc struct is filled out.

[Lei Zhang, 2016/06/30 22:29:34]

I added a comment here. There's several "is_modifiable" members in
components/printing/common/print_messages.h, and some of them are documented, so
there's probably enough documentation there. They all mean the same thing.

 
   // Set the new print settings.
   void SetSettings(std::unique_ptr<base::DictionaryValue> new_settings);
 
   // Starts the printing loop. Every pages are printed as soon as the data is
   // available. Makes sure the new_document is the right one.
   void StartPrinting(PrintedDocument* new_document);
 
   // Updates the printed document.
   void OnDocumentChanged(PrintedDocument* new_document);
@@ skipping 87 matching lines @@
 
   // Used to generate a WeakPtr for callbacks.
   base::WeakPtrFactory<PrintJobWorker> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PrintJobWorker);
 };
 
 }  // namespace printing
 
 #endif  // CHROME_BROWSER_PRINTING_PRINT_JOB_WORKER_H_