Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2114523002: Move more Mojo bindings helpers out of internal namespace (Closed)

Created:
4 years, 5 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 5 months ago
Reviewers:
yzshen1
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@group-controller
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move more Mojo bindings helpers out of internal namespace Moves the following things out of the mojo::internal namespace and moves their headers to mojo/public/cpp/bindings: - InterfaceId - Message flags (constants in Message rather than in internal) - MessageHeaderValidator - PipeControlMessageHandler - PipeControlMessageHandlerDelegate - PipeControlMessageProxy - SyncHandleWatcher This completes the set of existing helpers necessary to implement custom bindings endpoints with custom routing logic. BUG=612500 R=yzshen@chromium.org Committed: https://crrev.com/fb120de586f00981251a9bdfc8f952a4a8f91240 Cr-Commit-Position: refs/heads/master@{#403292}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -681 lines) Patch
M mojo/mojo_public.gypi View 1 2 7 chunks +6 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/BUILD.gn View 1 7 chunks +6 lines, -6 lines 0 comments Download
A + mojo/public/cpp/bindings/connector.h View 4 chunks +4 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/lib/binding_state.h View 2 chunks +2 lines, -2 lines 0 comments Download
D mojo/public/cpp/bindings/lib/connector.h View 1 chunk +0 lines, -213 lines 0 comments Download
M mojo/public/cpp/bindings/lib/connector.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_endpoint_client.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_ptr_state.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/message_builder.h View 4 chunks +4 lines, -4 lines 0 comments Download
D mojo/public/cpp/bindings/lib/message_header_validator.h View 1 chunk +0 lines, -33 lines 0 comments Download
M mojo/public/cpp/bindings/lib/message_header_validator.cc View 4 chunks +28 lines, -24 lines 0 comments Download
M mojo/public/cpp/bindings/lib/message_internal.h View 2 chunks +1 line, -7 lines 0 comments Download
M mojo/public/cpp/bindings/lib/multiplex_router.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/lib/multiplex_router.cc View 4 chunks +4 lines, -4 lines 0 comments Download
D mojo/public/cpp/bindings/lib/pipe_control_message_handler.h View 1 chunk +0 lines, -55 lines 0 comments Download
M mojo/public/cpp/bindings/lib/pipe_control_message_handler.cc View 4 chunks +9 lines, -9 lines 0 comments Download
D mojo/public/cpp/bindings/lib/pipe_control_message_handler_delegate.h View 1 chunk +0 lines, -28 lines 0 comments Download
D mojo/public/cpp/bindings/lib/pipe_control_message_proxy.h View 1 chunk +0 lines, -38 lines 0 comments Download
M mojo/public/cpp/bindings/lib/pipe_control_message_proxy.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M mojo/public/cpp/bindings/lib/router.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/router.cc View 5 chunks +8 lines, -8 lines 0 comments Download
D mojo/public/cpp/bindings/lib/sync_handle_watcher.h View 1 chunk +0 lines, -76 lines 0 comments Download
M mojo/public/cpp/bindings/lib/sync_handle_watcher.cc View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/validation_util.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/message.h View 1 chunk +4 lines, -0 lines 0 comments Download
A + mojo/public/cpp/bindings/message_header_validator.h View 2 chunks +3 lines, -5 lines 0 comments Download
A + mojo/public/cpp/bindings/pipe_control_message_handler.h View 3 chunks +4 lines, -6 lines 0 comments Download
A + mojo/public/cpp/bindings/pipe_control_message_handler_delegate.h View 2 chunks +3 lines, -5 lines 0 comments Download
A + mojo/public/cpp/bindings/pipe_control_message_proxy.h View 3 chunks +4 lines, -7 lines 0 comments Download
M mojo/public/cpp/bindings/strong_binding.h View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/cpp/bindings/sync_handle_watcher.h View 3 chunks +3 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/tests/connector_unittest.cc View 17 chunks +60 lines, -84 lines 0 comments Download
M mojo/public/cpp/bindings/tests/router_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/validation_unittest.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Ken Rockot(use gerrit already)
4 years, 5 months ago (2016-06-30 17:17:46 UTC) #1
yzshen1
lgtm
4 years, 5 months ago (2016-06-30 17:25:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114523002/40001
4 years, 5 months ago (2016-06-30 20:13:46 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-30 21:23:11 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 21:23:24 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 21:24:23 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fb120de586f00981251a9bdfc8f952a4a8f91240
Cr-Commit-Position: refs/heads/master@{#403292}

Powered by Google App Engine
This is Rietveld 408576698