Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: mojo/public/cpp/bindings/lib/validation_util.cc

Issue 2114523002: Move more Mojo bindings helpers out of internal namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@group-controller
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/bindings/lib/sync_handle_watcher.cc ('k') | mojo/public/cpp/bindings/message.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/lib/validation_util.cc
diff --git a/mojo/public/cpp/bindings/lib/validation_util.cc b/mojo/public/cpp/bindings/lib/validation_util.cc
index 353d32dd0f4cd9083ffb67d1d0807ec283e54579..9e635211651349af85baa002ba304b045f71f434 100644
--- a/mojo/public/cpp/bindings/lib/validation_util.cc
+++ b/mojo/public/cpp/bindings/lib/validation_util.cc
@@ -81,8 +81,8 @@ bool ValidateUnionHeaderAndClaimMemory(const void* data,
bool ValidateMessageIsRequestWithoutResponse(
const Message* message,
ValidationContext* validation_context) {
- if (message->has_flag(kMessageIsResponse) ||
- message->has_flag(kMessageExpectsResponse)) {
+ if (message->has_flag(Message::kFlagIsResponse) ||
+ message->has_flag(Message::kFlagExpectsResponse)) {
ReportValidationError(validation_context,
VALIDATION_ERROR_MESSAGE_HEADER_INVALID_FLAGS);
return false;
@@ -93,8 +93,8 @@ bool ValidateMessageIsRequestWithoutResponse(
bool ValidateMessageIsRequestExpectingResponse(
const Message* message,
ValidationContext* validation_context) {
- if (message->has_flag(kMessageIsResponse) ||
- !message->has_flag(kMessageExpectsResponse)) {
+ if (message->has_flag(Message::kFlagIsResponse) ||
+ !message->has_flag(Message::kFlagExpectsResponse)) {
ReportValidationError(validation_context,
VALIDATION_ERROR_MESSAGE_HEADER_INVALID_FLAGS);
return false;
@@ -104,8 +104,8 @@ bool ValidateMessageIsRequestExpectingResponse(
bool ValidateMessageIsResponse(const Message* message,
ValidationContext* validation_context) {
- if (message->has_flag(kMessageExpectsResponse) ||
- !message->has_flag(kMessageIsResponse)) {
+ if (message->has_flag(Message::kFlagExpectsResponse) ||
+ !message->has_flag(Message::kFlagIsResponse)) {
ReportValidationError(validation_context,
VALIDATION_ERROR_MESSAGE_HEADER_INVALID_FLAGS);
return false;
« no previous file with comments | « mojo/public/cpp/bindings/lib/sync_handle_watcher.cc ('k') | mojo/public/cpp/bindings/message.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698