Remove usage of MediaCodec.getName(), use proxy instead.

Remove usage of MediaCodec.getName(), use proxy instead.

This method does not exist API < 18 and it is simpler to just
trust the |require_software_codec| value which is the inverse
of |allow_autodetection_|.

BUG=613238, 622927, 624482
TEST=none

Committed: https://crrev.com/125c85c497ce34c57b28e83ec252a1c7b7f76231
Cr-Commit-Position: refs/heads/master@{#403197}

[DaleCurtis, 2016-06-30 00:26:59]

dalecurtis@chromium.org changed reviewers:
+ liberato@chromium.org, watk@chromium.org

[DaleCurtis, 2016-06-30 00:27:00]

Haven't tested yet. I think we might also want to avoid stopping the thread with
release pending given some of the hangs we've seen

[DaleCurtis, 2016-06-30 00:27:23]

Description was changed from

==========
Remove usage of MediaCodec.getName(), always post deletion.

This method does not exist API < 18 and it is simpler to just
always post the deletion and let it happen on the construction
thread.

BUG=613238,622927
TEST=none
==========

to

==========
Remove usage of MediaCodec.getName(), always post deletion.

This method does not exist API < 18 and it is simpler to just
always post the deletion and let it happen on the construction
thread.

BUG=613238,622927,624482
TEST=none
==========

[DaleCurtis, 2016-06-30 00:37:24]

Description was changed from

==========
Remove usage of MediaCodec.getName(), always post deletion.

This method does not exist API < 18 and it is simpler to just
always post the deletion and let it happen on the construction
thread.

BUG=613238,622927,624482
TEST=none
==========

to

==========
Remove usage of MediaCodec.getName(), use proxy instead.

This method does not exist API < 18 and it is simpler to just
trust the |require_software_codec| value which is the inverse
of |allow_autodetection_|.

BUG=613238,622927,624482
TEST=none
==========

[DaleCurtis, 2016-06-30 00:37:37]

Updated, can't always post or we'll accumulate mediacodecs forever.

[watk, 2016-06-30 00:38:21]

https://codereview.chromium.org/2114473002/diff/1/media/base/android/java/src...
File media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
(right):

https://codereview.chromium.org/2114473002/diff/1/media/base/android/java/src...
media/base/android/java/src/org/chromium/media/MediaCodecBridge.java:230: if
(Build.VERSION.SDK_INT >= Build.VERSION.JELLY_BEAN_MR2)
Needs to be Build.VERSION_CODES.JELLY_BEAN_MR2

[DaleCurtis, 2016-06-30 00:59:26]

https://codereview.chromium.org/2114473002/diff/1/media/base/android/java/src...
File media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
(right):

https://codereview.chromium.org/2114473002/diff/1/media/base/android/java/src...
media/base/android/java/src/org/chromium/media/MediaCodecBridge.java:230: if
(Build.VERSION.SDK_INT >= Build.VERSION.JELLY_BEAN_MR2)
On 2016/06/30 at 00:38:20, watk wrote:
> Needs to be Build.VERSION_CODES.JELLY_BEAN_MR2

Heh, impressed that's the only error given I wrote this on a mac :)

[DaleCurtis, 2016-06-30 01:02:05]

Frank, if you see this tonight and like the approach, hit the CQ so we can merge
this for next dev/beta cut.

[DaleCurtis, 2016-06-30 05:28:35]

The CQ bit was checked by dalecurtis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-30 05:28:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 06:39:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 06:39:24]

Dry run: This issue passed the CQ dry run.

[liberato (no reviews please), 2016-06-30 14:59:28]

sorry, laptop isn't connecting to corp so no email last night.

i like the approach, but i'm going to try it on my stress test to be sure that
it's not leaking codecs too much.

https://codereview.chromium.org/2114473002/diff/40001/media/gpu/android_video...
File media/gpu/android_video_decode_accelerator.cc (right):

https://codereview.chromium.org/2114473002/diff/40001/media/gpu/android_video...
media/gpu/android_video_decode_accelerator.cc:1423: if
(!codec_config_->allow_autodetection_) {
it'll leak software codecs when mediaserver first hangs, but i suppose that's
not a likely case.

also, this makes me realize that we should do the same thing in
OnCodecConfigured when assigning the new codec.

[liberato (no reviews please), 2016-06-30 16:35:13]

On 2016/06/30 14:59:28, liberato wrote:
> sorry, laptop isn't connecting to corp so no email last night.
> 
> i like the approach, but i'm going to try it on my stress test to be sure that
> it's not leaking codecs too much.
> 
>
https://codereview.chromium.org/2114473002/diff/40001/media/gpu/android_video...
> File media/gpu/android_video_decode_accelerator.cc (right):
> 
>
https://codereview.chromium.org/2114473002/diff/40001/media/gpu/android_video...
> media/gpu/android_video_decode_accelerator.cc:1423: if
> (!codec_config_->allow_autodetection_) {
> it'll leak software codecs when mediaserver first hangs, but i suppose that's
> not a likely case.
> 
> also, this makes me realize that we should do the same thing in
> OnCodecConfigured when assigning the new codec.

i added some logging to the pre-patched version of the code, and it looks like
it leaks only a few software instances on my stress test.

lgtm and cq, as reqested above.

[liberato (no reviews please), 2016-06-30 16:35:19]

The CQ bit was checked by liberato@chromium.org

[commit-bot: I haz the power, 2016-06-30 16:35:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 16:39:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-30 16:39:58]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 16:41:28]

Description was changed from

==========
Remove usage of MediaCodec.getName(), use proxy instead.

This method does not exist API < 18 and it is simpler to just
trust the |require_software_codec| value which is the inverse
of |allow_autodetection_|.

BUG=613238,622927,624482
TEST=none
==========

to

==========
Remove usage of MediaCodec.getName(), use proxy instead.

This method does not exist API < 18 and it is simpler to just
trust the |require_software_codec| value which is the inverse
of |allow_autodetection_|.

BUG=613238,622927,624482
TEST=none

Committed: https://crrev.com/125c85c497ce34c57b28e83ec252a1c7b7f76231
Cr-Commit-Position: refs/heads/master@{#403197}
==========

[commit-bot: I haz the power, 2016-06-30 16:41:30]

Patchset 3 (id:??) landed as
https://crrev.com/125c85c497ce34c57b28e83ec252a1c7b7f76231
Cr-Commit-Position: refs/heads/master@{#403197}